Icon library: bundled Lucide set + sanitized SVG uploads + icon picker - #69
Merged
Merged
Conversation
…on picker control - 1838 Lucide icons (ISC) shipped as manifest.json; inline SVG render, currentColor sizing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gap 1 of docs/research/12 closed. 1838 Lucide icons (ISC) shipped as manifest.json; closed-set icon inspector control (search grid, upload, legacy glyph); DOM allowlist sanitizer (wp_kses_svg does not exist in core); hostile SVG rejected 400; benign uploads sanitized at save and re-sanitized at render; temporary upload_mimes filters around the single sanitized write. e2e: full human flow (palette add, picker, save, frontend inline svg, hostile + benign upload fixtures). Gates: e2e 41/41, phpunit 49, phpstan8 0, phpcs silent, PC 0 errors/2 known warnings. Release asset intentionally untouched until wp.org approval.