fix(wporg): round-3 review fixes (REST caps, kses hardening, dynamic gettext) - #73
Merged
Merged
Conversation
- REST: page-creation route now requires edit_pages, library delete delete_pages (previously only post capabilities were checked for page actions) - REST: saved-pattern write/delete require manage_options (site-wide markup) - Hardening: hook renderer passes third-party output through wp_kses_post - i18n: tr() resolves via the core translation filter instead of a gettext call with a variable argument (last one flagged); catalog keeps POT literals - Version 0.1.2 + readme changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses round-3 automated review: page-scoped route capabilities, hook-output hardening, last variable-argument gettext call replaced with the core translation filter (catalog literals unchanged), version 0.1.2. Tested: 45/45 e2e, clean-install activation (tables via dbDelta, silent), phpunit/phpstan/phpcs green.