[DRAFT][Accessibility] Document WinAppSDK alternative for HighContrastChanged - #2491
[DRAFT][Accessibility] Document WinAppSDK alternative for HighContrastChanged#2491Ben Stolovitz (citelao) wants to merge 1 commit into
Conversation
prmerger-automator
Bot
added
do-not-merge
|
It seems that while the ThemeSettings API is the correct API to use to listen to theme changes, the Changed event does not fire when switching between High Contrast themes. I filed an internal bug to track this issue Bug 56208821: ThemeSettings.Changed event does not fire when switching between High Contrast themes |
John Kennedy (GrantMeStrength)
left a comment
John Kennedy (GrantMeStrength)
left a comment
There was a problem hiding this comment.
LGTM — accurate improvement. Approved.
|
Copilot /review |
John Kennedy (GrantMeStrength)
left a comment
John Kennedy (GrantMeStrength)
left a comment
There was a problem hiding this comment.
Reviewed ✅ — Documentation improvement looks good.
John Kennedy (GrantMeStrength)
assigned
John Kennedy (GrantMeStrength) and unassigned
KB (Karl-Bridge-Microsoft)
John Kennedy (GrantMeStrength)
added
the
needs-human-review
|
Niels Laute (@niels9001) Niels, what do you think? |
There was a problem hiding this comment.
Pull request overview
Documents the WinUI 3 alternative to AccessibilitySettings.HighContrastChanged.
Changes:
- Adds a WinUI 3 compatibility warning.
- Links to
ThemeSettings.Changedand the API mapping guide.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| ## -remarks | ||
|
|
||
| > [!WARNING] | ||
| > This method will not work in WinUI 3 apps. |
WinAppSDK devs devs will find that the
HighContrastChangedevent does not work (it may crashes!) in WinUI 3 apps. This change documents the replacement API.See similar change in WinAppSDK docs & issue in WinAppSDK codebase
Warning
HOLD until we validate this is a complete replacement.