fix: fail closed when API key region detection is inconclusive#194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
globalfallback--region global|cnduring API-key loginRoot cause
Region detection collapsed invalid credentials, blocked probes, and transient network failures into a successful
globalresult. Callers then persisted that unverified result, overwriting a valid China-region configuration and routing later requests to the wrong API host.The explicit-region recovery path still treated every validation exception as an authentication failure, so a blocked quota endpoint produced the same result as a rejected key.
Impact
Automatic detection remains fail-closed and leaves existing credentials unchanged when no region can be confirmed. Explicitly selecting a region now treats the user's choice as authoritative: confirmed 401/403 responses still reject the key, while network failures produce a warning and save the selected region so restricted-network users have a real recovery path.
Test reliability
Config command tests now use scoped spies or dry-run behavior instead of process-wide module mocks, preventing them from replacing the config loader used by login tests.
Fixes #191
Validation
bun test— 381 passedbun run typecheckbun run build:devgit diff --check