Repository navigation
chore(deps): bump @stellar/stellar-sdk from 15.0.1 to 17.2.1 - #233
dependabot[bot] wants to merge 1 commit into
Conversation
|
Verified locally; holding this one.
All one root cause: the XDR union accessor API is gone. v17 turns the unions into discriminated types, so the Not merging it as-is, and not fixing it in a dependabot PR either. Every one of those files is in the path that decodes contract data off the chain, and a wrong XDR branch there does not throw — it indexes the wrong value and we find out from a balance that disagrees with the network. That wants its own PR with a deliberate migration and a test that decodes known ledger entries, not a sed over Leaving this open as the tracking reference for the version. Filing the migration as a Wave issue so it gets done properly. |
b242736 to
839e145
Compare
|
Filed as #290, including the request for tests that decode captured real XDR — that is the piece that makes this migration safe to trust. |
A minor bump within the same major, unlike the four dependabot PRs still held here (#230 typescript 7, #232 express 5, #233 stellar-sdk 17, #234 graphql 17), each of which is a real migration. tsc --noEmit clean jest 75 suites, 1154 tests passing ws carries the GraphQL subscription transport, so the suite passing matters more than the version delta looks -- src/graphql/subscriptions.ts is 376 lines and #315 is open because most of it is untested. This bump does not change that, it just does not make it worse. Claude-Session: https://claude.ai/code/session_01USgemLt4Rnz4SGB1Srf3GB
839e145 to
c8ee32e
Compare
Bumps [@stellar/stellar-sdk](https://github.com/stellar/js-stellar-sdk) from 15.0.1 to 17.2.1. - [Release notes](https://github.com/stellar/js-stellar-sdk/releases) - [Changelog](https://github.com/stellar/js-stellar-sdk/blob/main/CHANGELOG.md) - [Commits](stellar/js-stellar-sdk@v15.0.1...v17.2.1) --- updated-dependencies: - dependency-name: "@stellar/stellar-sdk" dependency-version: 17.2.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
c8ee32e to
0d94cf2
Compare
|
Held, with a concrete reason rather than neglect — and there is a companion PR that should land with it. Why CI fails. This is a two-major jump (15 → 17) and the SDK replaced its XDR accessors with discriminated unions along the way: Those are the indexer's hot paths — The companion. #338 is open and attempts exactly this migration. It currently goes the wrong way — it introduces These two need to land together. Either PR alone leaves the tree broken: this one pins 17 while the code speaks 15, and #338 rewrites the code while Leaving it open as the tracking record for the bump until that happens. |
|
Superseded by #346. |
Bumps @stellar/stellar-sdk from 15.0.1 to 17.2.1.
Release notes
Sourced from @stellar/stellar-sdk's releases.
... (truncated)
Changelog
Sourced from @stellar/stellar-sdk's changelog.
... (truncated)
Commits
b489349chore(release): prepare v17.2.1 (#1767)c103c9bfix: order asset issuers and ScVal map keys the way the network does (#1766)53435c3docs: add release/support policy and security policy (#1729)7cfd51achore(release): prepare v17.2.0 (#1760)40a8376fix(contract): walk delegate trees in needsNonInvokerSigningBy (#1747)284f4d1docs(contract): explain what needsNonInvokerSigningBy can and cannot see (#1745)791e4cffix(contract): forward wallet signerAddress to default authorizer (#1744)a6ba91afix(contract): report when signAuthEntries signs no auth entry (#1743)7b6469efix(auth): verify bare signature callbacks against forAddress (#1742)74ac0c6docs: regroup the Migration Guide and fix the guides-local race (#1740)Install script changes
This version modifies
preparescript that runs during installation. Review the package contents before updating.