feat: updated Official Feed badge to allow for community feeds#152
feat: updated Official Feed badge to allow for community feeds#152Alessandro100 wants to merge 8 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR updates the “Official Feed” badge UX to support three states of feed verification (official=true, official=false for community-submitted, and unset/unknown), and wires the new badge into the feed search tables and feed detail pages.
Changes:
- Replaces
OfficialChipwith a newFeedVerificationChipthat can render both Official and Community badges (or nothing when unset). - Updates feed search tables and GTFS feed detail summary to use the new verification chip.
- Adds i18n strings for the new “Community Feed” labels/tooltips and removes the old verification badge style helper. (custom)
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/app/styles/VerificationBadge.styles.ts | Removes the old shared verification badge style helper. |
| src/app/screens/Feeds/SearchTable.tsx | Replaces OfficialChip usage with FeedVerificationChip in search results. |
| src/app/screens/Feeds/AdvancedSearchTable.tsx | Replaces OfficialChip usage with FeedVerificationChip in advanced search results. |
| src/app/screens/Feed/FeedView.tsx | Switches GTFS-RT verification display to the new chip (but currently still gated to official === true). |
| src/app/screens/Feed/components/DataQualitySummary.tsx | Updates GTFS detail summary to display the new verification chip (official/community). |
| src/app/components/OfficialChip.tsx | Removes the old chip component. |
| src/app/components/FeedVerificationChip.tsx | Adds the new unified verification chip component. |
| messages/fr.json | Adds French-namespace strings for community feed labels/tooltips. |
| messages/en.json | Adds English strings for community feed labels/tooltips. |
|
*Lighthouse ran on https://mobilitydatabase-k19hidagx-mobility-data.vercel.app/ * (Desktop)
*Lighthouse ran on https://mobilitydatabase-k19hidagx-mobility-data.vercel.app/feeds * (Desktop)
*Lighthouse ran on https://mobilitydatabase-k19hidagx-mobility-data.vercel.app/feeds/gtfs/mdb-2126 * (Desktop)
*Lighthouse ran on https://mobilitydatabase-k19hidagx-mobility-data.vercel.app/feeds/gtfs_rt/mdb-2585 * (Desktop)
*Lighthouse ran on https://mobilitydatabase-k19hidagx-mobility-data.vercel.app/feeds/gbfs/gbfs-flamingo_porirua * (Desktop)
|
|
@Alessandro100 Change "Community feed: Not officially confirmed by the transit provider." to "Community feed: Created by a third party unaffiliated with the transit provider." |
Summary:
closes #142
Updates the Official Feed badge component to allow for
falsevalues indicating that it's a community submitted feedExpected behavior:
When a feed has the explicit value
is_official=falseit will display it as a community feed in the search page and in the feed detail pageTesting tips:
In the search page, search for "Romania" which should display some community submitted feeds, hover over the new icon to display the tool tip. Click on the community feed and view the community status chip at the top of the page
Please make sure these boxes are checked before submitting your pull request - thanks!
yarn testto make sure you didn't break anything