cli: extend managed deadlines and prepare bounded transports - #685
Draft
aaltshuler wants to merge 7 commits into
Draft
cli: extend managed deadlines and prepare bounded transports#685aaltshuler wants to merge 7 commits into
aaltshuler wants to merge 7 commits into
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Managed queries and mutations can exceed the current 10-second request
deadline while the server is still working. Increase their total deadline to
30 seconds, including connection establishment and response reading, while
retaining the 10-second connection limit. Redirects and automatic retries are
disabled, responses remain bounded to 8 MiB, and a timed-out mutation may have
committed and requires independent reconciliation.
Also prepare bounded transport for the existing NDJSON load and native commit
list/show endpoints. Load checks the exact UTF-8 input against a 32 MiB limit
before dispatch and has its own 300-second request deadline. Prepared commit
reads share the 30-second managed request deadline. Server fixtures preserve
signed graph/action ceilings, Cedar authorization, branch-creation checks and
authenticated commit attribution.
The command activation boundary follows
RFC 0059 / PR #675:
query/mutation limits. This narrow agreement does not accept the broader RFC.
load,commit listandcommit showon ordinaryaddressing; these commands do not acquire credentials from folder context.
connection selection, exact API/cluster/endpoint binding, action mapping and
destination/effect evidence. The prepared transport alone does not qualify
those commands. Accepted served-catalog scope in CLI: support queries list through --server and --graph #653 remains separate.
RFC 0053 records the implemented limits and preparation boundary. User docs
and release notes describe the query/mutation deadline change.
Local validation passed: all 110 CLI unit tests, strict all-target workspace
Clippy in both the default and failpoint feature configurations, formatting,
documentation checks (133 Markdown files), spelling and diff checks. The
deadline regressions fail with the old 10-second limit and pass with 30 seconds;
they preserve complete successful receipts after 10 seconds and observe one
request on timeout across ad-hoc, stored, conditional and branch mutations.