Skip to content

Fix graph state races, restoration, exports, and data adapters - #12

Merged
aaltshuler merged 1 commit into
mainfrom
codex/fix-full-code-review
Sep 4, 2026
Merged

Fix graph state races, restoration, exports, and data adapters#12
aaltshuler merged 1 commit into
mainfrom
codex/fix-full-code-review

Conversation

@aaltshuler

Copy link
Copy Markdown
Contributor

Prevent stale asynchronous work, cached UI state, and incomplete restoration from corrupting the current graph view. This fixes all 16 verified review findings and adds permanent regressions across the five packages and demo.

  • Core: supersede pending worker snapshots when ingestion publishes; cancel staged restores on dataset replacement or destruction; preserve restored positions and paused simulation state before readiness and during context recovery; refresh scale domains, colors, sizes, and fold counts during history replay; pin node and edge visibility for data exports, including underlying parallel edges.
  • React and demo: keep table attributes searchable after zero matches, invalidate navigator scene caches, refresh same-ID tooltip content without restarting its delay, and reflect shared-view styling alongside controlled selection.
  • Cosmos: calculate clamped fitting from the same transition destination positions as native fitting. The exact 3.4.0 private helper dependency is documented and covered by real-browser shrink/expand regressions.
  • Data and Omnigraph: recursively materialize Arrow containers and normalize nested values, honor cancellation for existing Arrow tables and at final ingestion boundaries, normalize temporal lists, and allocate collision-free generated node/edge interface names.

Includes a patch changeset for all five packages.

Validation passed locally:

  • pnpm check: boundaries, internal anchors, Cosmos pin, lint, typechecks, 1,844 package tests, and 23 performance-gate tests.
  • pnpm build, pnpm smoke, pnpm demo:build, and pnpm storybook:build.
  • pnpm --filter orbit-demo e2e: all 49 browser tests, including the new camera and selected/styled shared-view regressions. The context-recovery browser test also passed again after the final recovery change.
  • pnpm probe:node, pnpm svg:node-fixture, and git diff --check.

@aaltshuler
aaltshuler merged commit a96118d into main Sep 4, 2026
4 checks passed
@aaltshuler
aaltshuler deleted the codex/fix-full-code-review branch September 4, 2026 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant