Skip to content

Fix/2026 10 14/web ci green - #69

Merged
janakhpon merged 2 commits into
mainfrom
fix/2026-10-14/web-ci-green
Oct 14, 2026
Merged

janakhpon merged 2 commits into
mainfrom
fix/2026-10-14/web-ci-green

Conversation

@janakhpon

Copy link
Copy Markdown
Member

What changed

Why

How it was verified

  • pnpm --filter ./apps/web test
  • pnpm --filter ./apps/web run lint
  • cd services/feedback && go vet ./... && go test ./... (if Go changed)
  • cd apps/cli && cargo fmt --check && cargo clippy --all-targets -- -D warnings && cargo test
    (if the CLI changed; the PDF tests need Poppler and MONOCR_PDF_FIXTURE, see apps/cli/README.md)
  • Android unit tests, if Android changed: cd apps/android && ./gradlew testDebugUnitTest
    (needs JAVA_HOME on Android Studio's JBR; see apps/android/README.md).
    The android job runs these on every push. The instrumented tests in
    app/src/androidTest/ run in no CI job, so run them on a device if you touched them.
  • iOS MonOcrCore tests, if iOS changed: cd apps/ios && sh Scripts/swift-test.sh.
    The ios-core job runs these on every push, so this is a faster copy of a
    gate that does exist. The app target is still not built anywhere.

Claims

- restore SvelteKit 2, adapter-cloudflare 7, vite 7, vite-plugin-svelte 6, vitest 4, TypeScript 5, prettier-plugin-svelte 3, @types/node 25, dotenv 17, googleapis 171
- keep the minor and patch updates, including onnxruntime-web 1.30
- keep pdfjs-dist at 4.10.38: the merge left the lockfile at 6.4.299 against a 4.10.38 manifest, which fails every frozen install
- typescript-eslint cannot run TypeScript 7, SvelteKit 3 drops svelte.config.js, and prettier-plugin-svelte 4 reformats pages: each needs its own migration
- lint, type-check, 214 unit tests, build and a frozen install all pass
- pin onnxruntime-web to ~1.24.3: its jsep.wasm is 23.86 MiB; 1.26.0 is 25.02, 1.27.0 is 25.58, 1.29.0 is 26.51 and 1.30.0 is 27.00
- Cloudflare Pages rejects any file over 25 MiB, which is why the deploy failed once 1.30.0 merged
- the app loads the jsep build for WebGPU, so dropping it would change behaviour
- lint, type-check, 214 unit tests, build and a frozen install pass; no output file exceeds 25 MiB
@janakhpon
janakhpon merged commit cb4756c into main Oct 14, 2026
17 checks passed
@janakhpon
janakhpon deleted the fix/2026-10-14/web-ci-green branch October 14, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant