Announce releases and tags - #32
Merged
Merged
Conversation
GitHub sends release and create; neither reached any app here, so a flow could hear an issue open and not hear a ship. Three emissions rather than two. GitHub already separates a full release from a pre-release, and a subscriber pays for a delivery before its own conditions run, so released and prereleased are two ids instead of one published plus a boolean nobody can narrow on. A tag carries no branch and there is no honest way to give it one: a tag points at a commit and master_branch is the repository's default. The branch question belongs to a release, where target_commitish answers it, so list-branches fills that control. An announcement now carries its own returns and its own builder. Two side tables keyed on the event name held while everything was issue-shaped; a tag has no number and no title. Needs Contents: read, which is what GitHub delivers both events under. Existing installations stay on the grant they approved until an owner approves the new one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GitHub sends
releaseandcreate. Neither reached any app here, so an automation could hear an issue open and could not hear a ship — a release going out, or a tag being pushed.What changed
Three new emissions and one new read.
release-publishedrelease/releasedprerelease-publishedrelease/prereleasedtag-createdcreate/ref_type: taglist-branchesis a new read, filling the control that narrows a release trigger to the branch it was cut from.Three decisions worth arguing about:
publishedplus a flag. GitHub already separatesreleasedfromprereleased. A subscriber pays for a delivery before any of its own conditions run, so "only what we ship" has to be answerable at subscription time — a boolean on one emission means every nightly pre-release costs a run first.master_branchon that payload is the repository's default and is the same answer whatever was tagged. The branch question belongs to a release, wheretarget_commitishreally answers it.returnsand its own builder. Two side tables keyed on the GitHub event name held for exactly as long as every announcement was issue-shaped. A tag has no number and no title.Permissions — needs an operator step
Both events are delivered only to an app holding
contents: read, soPERMISSIONSgains it (read-only; nothing here writes through it, nothing reads a file).For an app already registered, this has to be changed on the GitHub App's Permissions & events page — GitHub has no API for an app to widen itself — and then every installation stays on the grant its owner already approved until they approve the new one. Until then the events do not arrive and nothing looks broken. README gained an "Upgrading an app that is already registered" section saying so.
Testing
The manifest fixtures gained one delivery per new emission, plus a case that pins the
creatediscriminator: a branch creation arrives on the same event and must translate to nothing.