Repository navigation
feat(items): the excellent options in data (CI run for sven-n/MuMain#1098) - #174
Merged
Merged
Conversation
The excellent options move from code into data, as OpenMU's three excellent definitions in Options/Excellent.json,
linked by the option rules, and "excellent" comes to mean "has an active excellent option" (HasExcellentOptions).
- The option type "excellent": the excellent byte turns a definition's options 1 to 6 on. A value can add terms on
hero attributes (level, totalLevel, masterLevel), resolved when the options load and stopping at 0 and 65535.
- The game gives an item its excellent options from the definitions it links; the effect table maps each attribute
to the slot the stat code reads, and the stats add the damage, wizardry and defense rate per cent from the slots.
- The stat formulas, the name, the excellent durability, the tooltip state and the ground label ask for active
excellent options. Wings with wing options and the Horn of Fenrir (whose byte is its kind) aren't excellent by
the byte; Fenrir with a kind keeps the excellent ground label of the original client.
- The formula texts show their numbers from the data ({value}, the new {divisor}).
- Data Checks: wings and horn mounts that link excellent options, and {divisor} texts without one divisor term.
- Picking a character forgets the master level of the hero before until the server sends the new hero's.
- Arrows and bolts and the other items that can't be excellent no longer show excellent looks when the byte is set.
- Item Requirements counts excellent from the draft's own links; docs and tests for all of it.
Mosch0512
force-pushed
the
feat/item-options-9a3
branch
from
November 12, 2026 00:51
e8edaf5 to
76b589a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI run for sven-n#1098 on the fork, which also runs the Windows, macOS and Linux jobs. Close it after the run; don't merge it (the fork's main mirrors upstream).