[Mosch0512]

The fourth pull request of the item options design (docs/superpowers/specs/2026-11-04-item-options-design.md, 9a4, after 9a3 sven-n#1098), with the fix that comes right after 9a3: the excellent "+level / 20" counts level plus master level (O26), and the ancient bonus moves from code into data (O14). The move keeps every tooltip and every ancient item's stats; the two changes it needs come before it in commits of their own, listed under "What the player sees differently".

What changes

• Excellent "+level / 20" (fix, O22/O26, P16): the two options' term in Options/Excellent.json reads totalLevel instead of level, so it divides level plus master level, rounded down, as the decompiled Season 6 servers and OpenMU do. Only the data changes; the client already reads totalLevel since 9a3.
• Ancient bonus above level 2 (fix, before the move): the code multiplied the bonus level by 5, so a level of 3 to 15, which the ancient byte holds but no server sends, gave +15 to +75. A level above 2 now counts as level 2, as the definition's list will give it.
• Type ancientBonus: the ancient byte's bonus level (ITEM::AncientBonusOption, the high four bits of the open source client's ancient byte) is the level; a definition has one option without a number, its value taken from the list at that level.
• Type ancientOption: known to the loader for the item sets (phase 10), its options numbered from 1. No definition has it yet; the set options stay where they are.
• Data/Items/Options/Ancient.json: four definitions with OpenMU's labels (OpenMU builds their GUIDs from the attribute: 00000083-0030-<first two bytes of the attribute's id>) and no server values (OpenMU gives the bonus through the sets, not randomly):

Name	Attribute	Value	attackType
ancientBonusStrength	totalStrength	[5, 10]	1
ancientBonusAgility	totalAgility	[5, 10]	2
ancientBonusEnergy	totalEnergy	[5, 10]	3
ancientBonusVitality	totalVitality	[5, 10]	4

• Which item has which bonus: no item links them. Until the item sets link a bonus to each item of a set, the item's attackType picks the definition by these names (O14), as the code before picked the stat; the option database looks the four names up when it loads.
• Tooltips/OptionTexts.json: four texts (increaseStrength, increaseAgility, increaseEnergy, increaseVitality) from the game's "Increase strength +%d" and the others in their 11 languages, %d as {value}. The vitality text keeps the game's "Increase stamina".
• The game: CSItemOption::RenderDefaultOptionText writes the bonus definition's lines with its value at the bonus level (GetDefaultOptionText's switch on attackType and its * 5 are gone), and getAllAddState / getAllAddOptionStatesbyCompare add the value without * 5 (GetDefaultOptionValue is gone), through one helper that the set options use too (AddToStat). The "Increase attribute damage" line of the elemental rings and pendants stays in code until the item sets (design section 15), now only below a bonus line. WriteDefinitionOptionLines hands its line writing to a new WriteOptionLines, which the bonus uses too.
• The stat a bonus raises comes from its definition's attribute: the effects table maps totalStrength … totalVitality of type ancientBonus to the set options' stat ids (AT_SET_OPTION_IMPROVE_STRENGTH …), which the stat code switches on. The design kept the stat from attackType (section 4: SET_OPTION_*); with the attribute deciding, an edited Ancient.json changes the stat as well as the line, and an attribute the client doesn't add gets the existing "the client computes no … this way" warning.
• Data Checks: the four ancient bonus definitions attackType picks get no "no item and no option rule links" warning (any other ancient bonus or set options do); an item that links an ancient type is a warning (the link does nothing); an attackType above 4 is a warning of the item checks (it picks no bonus, shown in Item Basics); a name attackType picks without an ancientBonus definition is a warning naming the file (those items show and add no bonus). The reader stops on a numbered ancient bonus option ("an ancientBonus option has no number"), a second one, and an ancient set option numbered 0. Item Basics still shows attackType as its byte; the editor's option windows come with 9a5.
• docs/item-data.md describes the fix, the types, the file, the attackType field and the checks.

What the player sees differently

• "Level / 20" gives more to a master: a level 400 hero with 200 master levels gets +30 instead of +20, in the character window and the stats. Heroes without a master level see no change.
• A bonus level above 2 counts as level 2 (+10) where the code before gave 5 per level. Season 6 sends 1 and 2 (OpenMU's bonus has levels 1 and 2), so no server item changes.

Checked

• The tooltip snapshot got three variants, the ancient bonus at levels 1 to 3, recorded with the code before (every item's hash changes once there, as each has 48 tooltips more); the level fix re-recorded the items whose level 3 changes from +15 to +10, and the move kept every hash.
• A test on the code before the move: each of the 334 items with an attackType adds 5 per bonus level to its own stat (61 strength, 24 agility, 15 energy, 234 vitality), 10 from level 2 on after the fix, and a broken one nothing; the move keeps it.
• New tests: the bonus comes from the definition attackType picks (strength, vitality), +5 / +10, the last entry above the list, none at level 0, with its line from the text ("Increase strength +10", "Increase stamina +5", blue); the stats add it for a worn item and not for a broken one, an edited list as written, to the stat another attribute names, and nothing for an attribute the client doesn't add; the excellent level / 20 of a master hero with the shipped data ((85 + 30) / 20 = 5); the reader reads and writes back both types and stops on the cases above; the database finds the bonus by attackType 1 to 4 and none outside; the effect rows; the Data Checks for links, unlinked definitions (also an extra bonus and set options), attackType above 4 and missing names with their file; the elemental rings' second line with and without the bonus line; the link order with the ancient types; an empty database picks no bonus.
• Windows x64 Release (editor build), on main 1211f03: every target builds without warnings, and ctest passes all 4066 tests, among them test_item_database (284 cases) and test_item_database_files (434).
• Linux (Ubuntu 24.04, GCC 13, editor build), on main 1211f03: each of the 17 commits builds, and test_item_database_files, test_item_database and rml_styling_regression_tests pass at each.
• clang-format 21.1.8 on the changed lines passes. cppcheck 2.13 on the changed files passes (CI runs 2.19).
• Not tried in game.