chore: prune redundant tests and remove legacy task-factory seam - #1573
Merged
Merged
Conversation
Remove defensive tests whose guarded old interfaces no longer exist, strict-duplicate coverage, tautological/mock-only tests, tests of third-party private internals, and dead fixtures identified by a full tests/ audit (#1572). - delete 9 test files; surgically prune redundant tests/assertions in 22 files, folding unique assertions into the g1 owner contract suite - remove src/unilab/tasks/compatibility.py and its seam: the registry closeout now enforces that legacy EnvCfg -> NpEnv factories cannot coexist with the canonical Manager-Based runtime - replace the outdated private _RslRlVecEnvWrapper copy with the production uni_rl wrapper - update 6 docs pages (en/zh_CN) that cited the deleted obs-alignment test to reference ObservationManager history buffers instead Issue: #1572
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/audit (7 parallel read-only audits, every candidate re-verified againstsrc/+ git history before removal): old-interface guards (reward_config/domain_rand/control_configlegacy-override loops, removed offpolicy option/kwarg guards,DrakeUniBatchBackend/A2JoystickCfgabsence assertions,_selected_sim_backend/obs_profilemarkers), strict-duplicate coverage (g1 owner compose tests, motrix-sac/td3 compose tests, reward-injection integration, migration-matrix subset, APPO init-no-crash, observation finite-policy subset), tautological tests (former-script frozen-copy parity family, mock self-test, no-signal compile override, self-referential obs-alignment file), tests of third-party internals with zero unilab contact (unisim mjwarp private suites, body-state copy, MjSpec compile), and dead conftest fixtures (mp_ctx/tiny_storage/tiny_weight_shapes).src/unilab/tasks/compatibility.py(zero production users): deleted its test file and the closeout seam test, dropped the"compatibility"migration target, and rewrote the registry closeout so it enforces that legacyEnvCfg -> NpEnvfactories cannot coexist with the canonical Manager-Based runtime._RslRlVecEnvWrappercopy intest_rsl_rl_runner.pywith the productionuni_rl.algos.rsl_rl.RslRlVecEnvWrapper.ObservationManagerper-term history buffers,tests/managers/test_observation_buffers_noise.py).fragment_files/terrain/genesis_device_id/pd_gains is Nonefor isaacgym/genesis owners).Linked Work
mainValidation
make test-allpassed on the final local head before this PR was created or updated — partially blocked by a pre-existing local environment issue, see belowCommands actually run (on final head
98df4068):The
test-covcollection errors are a pre-existing local environment defect, not caused by this PR: the venv hasmjbatch-uni 0.1.0whilepyproject.tomlrequires~=0.2.0, so every file that importsunisim.backend.mujoco.backendfails identically onmain(verified viagit stashbaseline: same 7 collection errors, same 39+1 runtime failures). A clean CI environment is the real gate for those files.Remote CI route:
main: current-head CI running, see checks below (link: https://github.com/Motphys/UniLab/pull/1573/checks).Impact
Artifacts
make test-benchmark-smoke34/35 (1 platform-optional skip)Checklist
mjbatch-uni ~=0.2.0(reinstall/rebuild) for the mujoco-backend test files; affectsmainequally.reward_configrouting tests (live code for external plugin packages).