Skip to content

[#108, #75, #76, #73] Read frame lengths from AMPCS; improve parameter update output products; improve error detection and reporting - #115

Merged
rmseng merged 6 commits into
mainfrom
mmtc-108-75-76-73-rebased-v2
Aug 18, 2026
Merged

[#108, #75, #76, #73] Read frame lengths from AMPCS; improve parameter update output products; improve error detection and reporting#115
rmseng merged 6 commits into
mainfrom
mmtc-108-75-76-73-rebased-v2

Add missing req'd keys to AMPCS tlm source test config files

f380c2e
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Aug 14, 2026 in 28s

Quality Gate passed

Issues
11 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 16 in mmtc-core/src/main/java/edu/jhuapl/sd/sig/mmtc/products/definition/TimeHistoryFileProductDefinition.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'java.util.stream.Collectors'. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_MMTC&issues=AaAB8Ia8-nu7-4qGXdMh&open=AaAB8Ia8-nu7-4qGXdMh&pullRequest=115

Check warning on line 59 in mmtc-core/src/main/java/edu/jhuapl/sd/sig/mmtc/products/definition/ParameterGroupUpdateFileProductDefinition.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

%n should be used in place of \n to produce the platform-specific line separator. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_MMTC&issues=AaAB8IaT-nu7-4qGXdMe&open=AaAB8IaT-nu7-4qGXdMe&pullRequest=115

Check failure on line 100 in mmtc-core/src/main/java/edu/jhuapl/sd/sig/mmtc/app/MmtcCli.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 18 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_MMTC&issues=AaAB8IWk-nu7-4qGXdMa&open=AaAB8IWk-nu7-4qGXdMa&pullRequest=115

Check warning on line 77 in mmtc-core/src/main/java/edu/jhuapl/sd/sig/mmtc/products/definition/TimeHistoryFileProductDefinition.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

%n should be used in place of \n to produce the platform-specific line separator. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_MMTC&issues=AaAB8Ia8-nu7-4qGXdMg&open=AaAB8Ia8-nu7-4qGXdMg&pullRequest=115

Check warning on line 17 in mmtc-core/src/main/java/edu/jhuapl/sd/sig/mmtc/products/definition/TimeHistoryFileProductDefinition.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'java.util.stream.IntStream'. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_MMTC&issues=AaAB8Ia8-nu7-4qGXdMi&open=AaAB8Ia8-nu7-4qGXdMi&pullRequest=115

Check warning on line 274 in mmtc-core/src/main/java/edu/jhuapl/sd/sig/mmtc/products/util/BuiltInOutputProductMigrationManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested code block into a method. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_MMTC&issues=AaAB8Icr-nu7-4qGXdMj&open=AaAB8Icr-nu7-4qGXdMj&pullRequest=115

Check warning on line 67 in mmtc-core/src/main/java/edu/jhuapl/sd/sig/mmtc/products/definition/RawTlmTableProductDefinition.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

%n should be used in place of \n to produce the platform-specific line separator. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_MMTC&issues=AaAB8Iao-nu7-4qGXdMf&open=AaAB8Iao-nu7-4qGXdMf&pullRequest=115

Check warning on line 64 in mmtc-core/src/main/java/edu/jhuapl/sd/sig/mmtc/products/definition/AppendedFileOutputProductDefinition.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Immediately return this expression instead of assigning it to the temporary variable "zippedThRow". 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_MMTC&issues=AaAB8IaM-nu7-4qGXdMd&open=AaAB8IaM-nu7-4qGXdMd&pullRequest=115

Check warning on line 288 in mmtc-core/src/main/java/edu/jhuapl/sd/sig/mmtc/products/util/BuiltInOutputProductMigrationManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested code block into a method. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_MMTC&issues=AaAB8Icr-nu7-4qGXdMk&open=AaAB8Icr-nu7-4qGXdMk&pullRequest=115

Check warning on line 52 in mmtc-core/src/main/java/edu/jhuapl/sd/sig/mmtc/products/model/ParameterGroupUpdateFile.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused method parameter "parameterGroupUpdateFile". 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_MMTC&issues=AaAB8IZW-nu7-4qGXdMb&open=AaAB8IZW-nu7-4qGXdMb&pullRequest=115

Check warning on line 25 in mmtc-core/src/main/java/edu/jhuapl/sd/sig/mmtc/products/model/UplinkCommand.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "sclk_coarse" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=NASA-AMMOS_MMTC&issues=AaAB8IZ4-nu7-4qGXdMc&open=AaAB8IZ4-nu7-4qGXdMc&pullRequest=115
View more details on SonarQubeCloud