chore(stage): count text-editor view as observation - #835
Conversation
The Anthropic SDK has a built in tool definition that looks like edit but can be read. Now we handle both. This is pretty niche, for custom clients using that SDK. AI keeps wanting to fix it though, so here it is. The fix is only 3 lines, rest is tests. Fixes: https://linear.app/nvidia/issue/SWITCH-1565 Assisted-by: Claude:Opus 5.5 high Signed-off-by: Graham King <grahamk@nvidia.com>
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: NVIDIA-NeMo/Switchyard/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughEditor tool calls with command "view" are classified as observations. Tests cover classification for both editor tools, other commands, extracted signals, and routing to the capable model. ChangesEditor View Classification and Routing
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Editor view calls are covered by classification and routing tests; no actionable issue remains before normal merge checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
A rabbit taps a tool to view Comment |
The Anthropic SDK has a built in tool definition for
str_replace_based_edit_tool, that that looks like edit but canbe read. Now we handle both.
This is pretty niche, for custom clients using that SDK. AI keeps wanting to fix it though, so here it is.
The fix is only 3 lines, rest is tests.
Fixes: https://linear.app/nvidia/issue/SWITCH-1565
Assisted-by: Claude:Opus 5.5 high
Signed-off-by: Graham King grahamk@nvidia.com