test(webxr): cover control-panel positioning settings (depends on #1140) - #1141
Open
gareth-morgan-nv wants to merge 3 commits into
Open
gareth-morgan-nv wants to merge 3 commits into
gareth-morgan-nv wants to merge 3 commits into
Conversation
Adds ControlPanelPositionTest.spec.js against the real App.tsx + MockCloudXR, covering the controlPanelPosition/Distance/Height/ AngleDegrees settings, the R-key reset, and Track Headset mode from gmorgan/reset-panel-key - not yet merged into this branch's base (gmorgan/client-ui-mock-tests), so all 7 tests currently fail here as expected (missing settings elements, no panel-pose console.debug line). Confirmed red against this branch; will go green once reset-panel-key lands. All assertions go through the single "[CloudXRUI] headset=... relative=... world=..." console.debug line - the only host-observable signal for the panel's actual world position, since there is no other way to read a Three.js object's world position from outside the page. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Gareth Morgan <gmorgan@nvidia.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: NVIDIA/IsaacCapture/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
3 of 4 tasks
gareth-morgan-nv
requested review from
AndreusNvidius,
jiwenc-nv and
yanziz-nvidia
September 28, 2026 23:27
gareth-morgan-nv
added a commit
that referenced
this pull request
Sep 28, 2026
Real coverage now lives in ControlPanelPositionTest.spec.js (gmorgan/reset-panel-tests, #1141), against the actual fix (gmorgan/reset-panel-key, #1140). This test only ever checked that panelHiddenAtStart correctly drove the panelHidden state - it never touched the real failure mode (panel/handle out of reach after the operator moves), and its own comment already said as much. Keeping it under this file's "state reproduction" framing was misleading about what it actually covered. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Gareth Morgan <gmorgan@nvidia.com>
…to gmorgan/reset-panel-tests
…onTest too Same fix as #1136 (commit 271a009, merged in from gmorgan/client-ui-mock-tests): "IWER DevUI initialized with XR device." logs before installRuntime() and is skipped on the supported no-DevUI path - wait for LoadIWER.ts's "IWER runtime installed." instead. This file's own tests remain intentionally red against this branch's base (the reset-panel-key feature they cover isn't merged here yet) - verified AppMockTest.spec.js still passes and lint/jest are clean. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Gareth Morgan <gmorgan@nvidia.com>
gareth-morgan-nv
added a commit
that referenced
this pull request
Sep 29, 2026
Real coverage now lives in ControlPanelPositionTest.spec.js (gmorgan/reset-panel-tests, #1141), against the actual fix (gmorgan/reset-panel-key, #1140). This test only ever checked that panelHiddenAtStart correctly drove the panelHidden state - it never touched the real failure mode (panel/handle out of reach after the operator moves), and its own comment already said as much. Keeping it under this file's "state reproduction" framing was misleading about what it actually covered. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Gareth Morgan <gmorgan@nvidia.com>
gareth-morgan-nv
added a commit
that referenced
this pull request
Sep 29, 2026
Real coverage now lives in ControlPanelPositionTest.spec.js (gmorgan/reset-panel-tests, #1141), against the actual fix (gmorgan/reset-panel-key, #1140). This test only ever checked that panelHiddenAtStart correctly drove the panelHidden state - it never touched the real failure mode (panel/handle out of reach after the operator moves), and its own comment already said as much. Keeping it under this file's "state reproduction" framing was misleading about what it actually covered. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Gareth Morgan <gmorgan@nvidia.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
ControlPanelPositionTest.spec.jscovering the control-panel positioning/tracking work in #1140 (controlPanelPosition/Distance/Height/AngleDegreessettings, theR-key reset, and Track Headset mode).This branch does NOT include #1140's code (deliberately) — its base is
gmorgan/client-ui-mock-tests, notgmorgan/reset-panel-key. All 7 tests currently fail (red) against this base, since the settings elements and the[CloudXRUI] headset=... relative=... world=...console.debug line don't exist yet. They're expected to go green once #1140 merges and this branch is rebased onto it.All assertions go through that single console.debug line — the only host-observable signal for where the panel actually ended up, since there's no other way to read a Three.js object's world position from outside the page.
Test plan
npx playwright test ControlPanelPositionTest.spec.js🤖 Generated with Claude Code