ci: Add selective unit testing support using pytest-impacted - #6969
Draft
balasaajay wants to merge 5 commits into
Draft
ci: Add selective unit testing support using pytest-impacted#6969balasaajay wants to merge 5 commits into
balasaajay wants to merge 5 commits into
Conversation
- Introduced a new configuration in `pyproject.toml` for selective testing. - Updated CI workflows to handle selective unit tests based on PR labels. - Enhanced action inputs to allow passing specific unit test files. - Added documentation on selective unit testing in `tests/README.md`. - Modified test scripts to support selective test execution. This change enables more efficient testing by only running affected unit tests in pull requests labeled for selective testing. Signed-off-by: Ajay Balasa <abalasa@nvidia.com>
svcnvidia-nemo-ci
marked this pull request as draft
August 29, 2026 07:01
Contributor
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
- Added support for running selective unit tests on the latest commit in the CI workflow. - Updated job outputs to include `latest_commit_tests` based on PR labels. - Modified logic to handle scenarios where the latest commit needs to be checked out for testing. This change improves testing flexibility by allowing tests to be run on the most recent commit in addition to standard selective tests. Signed-off-by: Ajay Balasa <abalasa@nvidia.com>
Contributor
Author
|
/ok to test d7533f2 |
- Moved the generation of `unit-test-buckets.json` to a different location in the CI workflow for improved clarity and organization. - This change ensures that the bucket information is generated before it is utilized in the workflow. Signed-off-by: Ajay Balasa <abalasa@nvidia.com>
Contributor
Author
|
/ok to test 165e585 |
Contributor
Author
|
/ok to test 637bd22 |
…uct decode step preparation. Signed-off-by: Ajay Balasa <abalasa@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
pyproject.tomlfor selective testing.tests/README.md.This change enables more efficient testing by only running affected unit tests in pull requests labeled for selective testing.
Issue tracking
For PRs from open-source community contributors:
Linked issue:
Contribution process
Pre-checks
Code review
Feel free to message or comment @NVIDIA/mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of mcore-engineers will be able to merge your PR.