Skip to content

security(claude-review): AUT-2169 isolate analysis from publication - #6972

Draft
svcnemo-autobot wants to merge 4 commits into
NVIDIA:mainfrom
svcnemo-autobot:security/isolated-claude-review-v2
Draft

security(claude-review): AUT-2169 isolate analysis from publication#6972
svcnemo-autobot wants to merge 4 commits into
NVIDIA:mainfrom
svcnemo-autobot:security/isolated-claude-review-v2

Conversation

@svcnemo-autobot

Copy link
Copy Markdown
Collaborator

Background

Preserve Megatron-LM review behavior while separating read-only analysis from validated publication.

What changed

  • Enforce exact light/strict commands and explicit reviewer authorization.
  • Build bounded immutable BASE/MERGE_BASE/HEAD context from trusted base content.
  • Separate schema-constrained analysis from deterministic OIDC claude[bot] publication.
  • Replace approval with a non-approving LGTM comment.
  • Harden CLI failure handling and split bounded context serving into its own trusted module.

Details

flowchart LR
  C[Authorized command] --> X[Immutable context]
  X --> A[Read-only analysis]
  A --> V[Deterministic validation]
  V --> P[claude bot COMMENT publication]
Loading

Analysis has no publication or OIDC permission. The publisher verifies trusted modules and validates revisions, coverage, findings, paths, sides, lines, and limits before COMMENT-only publication. Binary, symlink, submodule, special-file, and large-change handling fails closed.

Tested

  • 50 focused parser, authorization, context, schema, safety, workflow-boundary, and publisher tests
  • YAML parsing and targeted actionlint
  • Ruff, Black 26.3.0, isort, and Python compilation
  • CLI error-path and prohibited-reference scans
  • git diff --check unavailable because the managed file-only checkout omits Git metadata; CI remains authoritative

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
@svcnemo-autobot
svcnemo-autobot requested a review from a team as a code owner August 29, 2026 09:58
@copy-pr-bot

copy-pr-bot Bot commented Aug 29, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci
svcnvidia-nemo-ci marked this pull request as draft August 29, 2026 09:59
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant