Repository navigation
Fix signal-terminated nvidia-smi queries - #5543
Open
fallintoplace wants to merge 1 commit into
Open
fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
Signed-off-by: Minh Vu <vuhoangminh97@gmail.com>
Contributor
[Low impact] This PR appears safe to merge. SummaryGPU queries now raise when
Reviews (1) · Last reviewed commit: "Fix signal-terminated nvidia-smi queries" · Reviewed by Greptile |
chesterxgchen
approved these changes
Oct 26, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5543 +/- ##
==========================================
+ Coverage 71.65% 71.66% +0.01%
==========================================
Files 1048 1048
Lines 112323 112323
==========================================
+ Hits 80480 80493 +13
+ Misses 31843 31830 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5542.
Description
What: Report signal-terminated
nvidia-smicommands as failed GPU queries.Why: Signal exits have negative return codes. The current check treats them as success and can report no GPUs.
Implementation: Check
returncode != 0and add regressions for exit codes1,-9, and-15.Types of changes
Testing
Risk
Low. Only previously accepted negative exit codes now raise, like positive failures.
How to revert
Revert the commit. No config or saved-state changes.