Skip to content

Tamil TN Cardinal Semiotic Class - #449

Open
surendran-246 wants to merge 37 commits into
NVIDIA:staging/tamil_tn_v1from
surendran-246:feat-ta-cardinal
Open

Tamil TN Cardinal Semiotic Class#449
surendran-246 wants to merge 37 commits into
NVIDIA:staging/tamil_tn_v1from
surendran-246:feat-ta-cardinal

Conversation

@surendran-246

@surendran-246 surendran-246 commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Before your PR is "Ready for review"

Pre checks:

  • Have you signed your commits? Use git commit -s to sign.
  • Do all unittests finish successfully before sending PR?
    1. pytest or (if your machine does not have GPU) pytest --cpu from the root folder (given you marked your test cases accordingly @pytest.mark.run_only_on('CPU')).
    2. Sparrowhawk tests bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
  • If you are adding a new feature: Have you added test cases for both pytest and Sparrowhawk here.
  • Have you added __init__.py for every folder and subfolder, including data folder which has .TSV files?
  • Have you followed codeQL results and removed unused variables and imports (report is at the bottom of the PR in github review box) ?
  • Have you added the correct license header Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. to all newly added Python files?
  • If you copied nemo_text_processing/text_normalization/en/graph_utils.py your header's second line should be Copyright 2015 and onwards Google, Inc.. See an example here.
  • Remove import guards (try import: ... except: ...) if not already done.
  • If you added a new language or a new feature please update the NeMo documentation (lives in different repo).
  • Have you added your language support to tools/text_processing_deployment/pynini_export.py.

PR Type:

  • New Feature
  • Bugfix
  • Documentation
  • Test

If you haven't finished some of the above items you can still open "Draft" PR.

surendran-246 and others added 10 commits July 7, 2026 13:51
@surendran-246
feat(ta): add cardinal TN tagger, verbalizer and test cases
856a301 
Signed-off-by: surendran-246 <surendrans@nvidia.com>
@surendran-246
feat(ta): address review comments
7ebabdf 
Signed-off-by: surendran-246 <surendrans@nvidia.com>
@surendran-246
message
d68701b 
Signed-off-by: surendran-246 <surendrans@nvidia.com>
@surendran-246
Updated Ta Cardinal
c2fc100 
Signed-off-by: surendran-246 <surendrans@nvidia.com>
@surendran-246
cardinal implementation
f9d575d 
Signed-off-by: surendran-246 <surendrans@nvidia.com>
@surendran-246
cardinal file
fcfcb3e 
Signed-off-by: surendran-246 <surendrans@nvidia.com>
@surendran-246
Updated cardinal file
423f239 
Signed-off-by: surendran-246 <surendrans@nvidia.com>
@surendran-246
Updated cardinal
5a39ceb 
Signed-off-by: surendran-246 <surendrans@nvidia.com>
@pre-commit-ci @surendran-246
[pre-commit.ci] auto fixes from pre-commit.com hooks
a0815e9 
for more information, see https://pre-commit.ci

Signed-off-by: surendran-246 <surendrans@nvidia.com>
@surendran-246
Cardinal updated file
eaf2223 
Signed-off-by: surendran-246 <surendrans@nvidia.com>
@surendran-246
Updated cardinal
c0e51f1 
Signed-off-by: surendran-246 <surendrans@nvidia.com>
@surendran-246 surendran-246 changed the title Tamil language cardinal semiotic class Tamil TN Cardinal Semiotic Class Jul 7, 2026
@surendran-246
surendran-246 marked this pull request as ready for review July 7, 2026 10:50
surendran-246 and others added 6 commits July 8, 2026 11:04
@surendran-246
Updated Cardinal
a0cd909 
Signed-off-by: surendran-246 <surendrans@nvidia.com>
@surendran-246
Added Cardinal
4761e67 
Signed-off-by: surendran-246 <surendrans@nvidia.com>
@surendran-246
Ta cardinal
301db6f 
Signed-off-by: surendran-246 <surendrans@nvidia.com>
@surendran-246
Added Cardinal file
60b9d58 
Signed-off-by: surendran-246 <surendrans@nvidia.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
fe805eb 
for more information, see https://pre-commit.ci
@surendran-246
Updated Cardinal file
e2e7996 
Signed-off-by: surendran-246 <surendrans@nvidia.com>
@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions Bot added the Stale label Jul 23, 2026
@surendran-246
Updated TA Cardinal
2907744 
Signed-off-by: surendran-246 <surendrans@nvidia.com>
surendran-246 and others added 2 commits July 23, 2026 18:44
@github-actions github-actions Bot removed the Stale label Jul 24, 2026
@surendran-246
Modified Cardinal
5561410 
Signed-off-by: surendran-246 <surendrans@nvidia.com>
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@surendran-246
Updated Jenkins file
f64f094 
Signed-off-by: surendran-246 <surendrans@nvidia.com>
@folivoramanh
folivoramanh requested a review from mgrafu August 28, 2026 03:45
@surendran-246

surendran-246 commented Aug 28, 2026

Copy link
Copy Markdown
Author

make sure both pytest and sparrrowhawk test pass

Completed the pytest and sparrowhawk tests, and both passed successfully.

mgrafu
mgrafu reviewed Sep 1, 2026
View reviewed changes
Comment thread nemo_text_processing/text_normalization/ta/data/numbers/hundred_ta.tsv Outdated
mgrafu
mgrafu reviewed Sep 1, 2026
View reviewed changes
Comment thread nemo_text_processing/text_normalization/ta/taggers/cardinal.py Outdated
teens_and_ties = teens_ties

# digit_oru
one_oru = pynini.cross("1", "ஒரு") | pynini.cross("௧", "ஒரு")

@mgrafu mgrafu Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's have everything be files instead of hardcoding

@surendran-246 surendran-246 Sep 3, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed and moved to one_oru.tsv file.

@mgrafu mgrafu Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't see the file in the PR?

mgrafu
mgrafu reviewed Sep 1, 2026
View reviewed changes
Comment thread nemo_text_processing/text_normalization/ta/taggers/cardinal.py Outdated
mgrafu
mgrafu reviewed Sep 1, 2026
View reviewed changes
Comment thread nemo_text_processing/text_normalization/ta/taggers/cardinal.py Outdated
mgrafu
mgrafu reviewed Sep 1, 2026
View reviewed changes
Comment thread nemo_text_processing/text_normalization/ta/taggers/cardinal.py
mgrafu
mgrafu reviewed Sep 1, 2026
View reviewed changes
Comment thread nemo_text_processing/text_normalization/ta/taggers/cardinal.py Outdated
mgrafu
mgrafu reviewed Sep 1, 2026
View reviewed changes
Comment thread nemo_text_processing/text_normalization/ta/taggers/punctuation.py
mgrafu
mgrafu reviewed Sep 1, 2026
View reviewed changes
Comment thread tools/text_processing_deployment/ta_tn_grammars_cased/verbalize/verbalize.far Outdated
mgrafu
mgrafu reviewed Sep 1, 2026
View reviewed changes
Comment thread tools/text_processing_deployment/ta_tn_grammars_cased/classify/tokenize_and_classify.far Outdated
mgrafu
mgrafu reviewed Sep 1, 2026
View reviewed changes
Comment thread tests/nemo_text_processing/ta/test_sparrowhawk_normalization.sh Outdated
mgrafu
mgrafu reviewed Sep 1, 2026
View reviewed changes
Comment thread tests/nemo_text_processing/ta/data_text_normalization/test_cases_cardinal.txt
mgrafu
mgrafu reviewed Sep 1, 2026
View reviewed changes
Comment thread nemo_text_processing/text_normalization/ta/verbalizers/verbalize_final.py Outdated
mgrafu
mgrafu reviewed Sep 1, 2026
View reviewed changes
Comment thread nemo_text_processing/text_normalization/ta/verbalizers/cardinal.py Outdated
mgrafu
mgrafu reviewed Sep 1, 2026
View reviewed changes
Comment thread nemo_text_processing/text_normalization/ta/verbalizers/cardinal.py Outdated
mgrafu
mgrafu reviewed Sep 1, 2026
View reviewed changes
Comment thread nemo_text_processing/text_normalization/ta/verbalizers/cardinal.py Outdated
@mgrafu

mgrafu commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

please make sure that all new directories have init files

surendran-246 and others added 2 commits September 3, 2026 10:23
@surendran-246
Updated Cardinal class based on the PR review
7fd892b 
Signed-off-by: surendran-246 <surendrans@nvidia.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
13368b6 
for more information, see https://pre-commit.ci
@surendran-246

surendran-246 commented Sep 3, 2026

Copy link
Copy Markdown
Author

Thanks for the review, @mgrafu. Addressed all the feedback comments.

Testing: Cardinal pytest passed; Sparrowhawk TNCardinal passed.

@surendran-246
surendran-246 requested a review from mgrafu September 3, 2026 06:08
surendran-246 and others added 5 commits September 3, 2026 17:33
@surendran-246
Added comma parsing + docstring
57ba53c 
Signed-off-by: surendran-246 <surendrans@nvidia.com>
@surendran-246
Added comma parsing + docstring
aad3c7a 
Signed-off-by: surendran-246 <surendrans@nvidia.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
316230f 
for more information, see https://pre-commit.ci
@surendran-246
Optimized cardinal file and added the init file
ddd96c2 
Signed-off-by: surendran-246 <surendrans@nvidia.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
a7df5e9 
for more information, see https://pre-commit.ci
mgrafu
mgrafu reviewed Sep 4, 2026
View reviewed changes
Comment thread tests/nemo_text_processing/ta/test_sparrowhawk_normalization.sh
done < "$input"
}

#testTNSpecialText() {

@mgrafu mgrafu Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgrafu mgrafu mgrafu left review comments
@folivoramanh folivoramanh Awaiting requested review from folivoramanh

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@surendran-246 @mgrafu @folivoramanh