-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix(scripts): convert editable file URLs portably #490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mohgupta-ship-it
wants to merge
69
commits into
main
Choose a base branch
from
codex/fix-editable-file-url-conversion
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+66
−1
Open
Changes from all commits
Commits
Show all changes
69 commits
Select commit
Hold shift + click to select a range
f9a51a0
fix(scripts): resolve editable file:// URLs with url2pathname
SanHsien 7f0cba5
fix(scripts): preserve file URL authority semantics
mohgupta-ship-it 1c0a099
fix(scripts): avoid file URL normalization drift
mohgupta-ship-it e853d00
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] 44beabd
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] 65c0c0e
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] cfe2d7c
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] ea42d8e
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] 1a12ad0
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] 0d44bad
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] e3b5b16
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] 41bdc15
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] c49dfc0
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] 0c84b0b
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] ce56485
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] a03d4a1
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] 1c641b5
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] b5dd31c
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] b9f764c
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] df4e447
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] e5ac4db
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] 922eb39
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] 95e53e0
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] 146ac44
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] 94a4506
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] 41f06f7
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] 4fef64d
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] ba5ee73
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] 3a5f6f6
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] 0dd5494
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] 3811f88
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] c5ae116
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] f22e8d2
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] 8ee0a4c
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] a14d1e0
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] f97cfd0
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] 380665b
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] f4f9927
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] 4ee6696
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] 5c5ddca
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] 457f945
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] a1f7a9f
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] 7ba28be
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] dec5ec8
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] eec5180
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] bde7f3b
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] 646ec62
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] 5baa9e9
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] 4c7c752
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] d9880b8
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] f9228e8
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] 3bd1689
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] ca411e9
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] a541527
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] a9f8c13
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] dfcc71f
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] 51a967a
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] 27b7e05
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] f06818c
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] e93ea01
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] d18a99f
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] 631b35c
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] c2a44b9
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] 2bc1c7e
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] cdc4e9f
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] 2befa9e
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] e9a49a4
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] 0fc64f7
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] f9a4bb9
Merge branch 'main' into codex/fix-editable-file-url-conversion
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P2] Preserve localhost double-leading paths
The accepted URL
file://localhost//pathreaches this branch withparsed.netloc == "localhost"andparsed.path == "//path", so the delimiter is not restored. On Python 3.14,url2pathnamereparses that input asfile://path(authoritypath); POSIX then raisesURLErrorinstead of resolving the local//path. The repository supports Python 3.14. Restore the delimiter for this accepted localhost form as well and add a regression that exercises the real adapter rather than only mocking its argument.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked this on the latest commit and can still reproduce the issue on Python 3.14:
file://localhost//tmp/depraisesURLErrorinstead of resolving the local path. Could we preserve//forlocalhostURLs too and add a regression test using the real converter?