Fix: report symlinked recursive skill skips in completeness (GH-495) - #595
Open
bniladridas wants to merge 2 commits into
Open
bniladridas wants to merge 2 commits into
bniladridas wants to merge 2 commits into
Conversation
bniladridas
commented
Sep 20, 2026
bniladridas
commented
Sep 20, 2026
bniladridas
commented
Sep 20, 2026
rng1995
requested changes
Sep 23, 2026
rng1995
left a comment
Collaborator
There was a problem hiding this comment.
[SkillSpector Review]
Changes requested at current head f62d938c0b962115dcc4865fd2edfcbc53767409.
Reviewed the full four-file diff, prior resolved author comments, discovery control flow, CLI aggregation, and new tests. The symlink counter reaches aggregate JSON/completeness, but it counts entries before applying discovery's explicit name exclusions. An intentionally ignored .git or node_modules symlink therefore creates omitted skills and incomplete coverage. Apply _SKIP_DIRS before incrementing omissions and add an ignored-name regression alongside an eligible linked skill. All six hosted checks pass; the branch conflicts with main. Tests were inspected, not run locally.
Signed-off-by: Niladri Das <125604915+bniladridas@users.noreply.github.com>
Signed-off-by: Niladri Das <125604915+bniladridas@users.noreply.github.com>
bniladridas
force-pushed
the
bniladridas/symlink-omission
branch
from
September 23, 2026 06:57
069fc2c to
1fcdb78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #495.
detect_skillsdeliberately refuses to follow symlinked entries duringrecursive discovery, but those skips were never counted. As a result a multi
skill scan whose tree contains symlinked skill directories reported
skills_omitted: 0,analysis_completeness.is_complete: true, and fullcoverage, although part of the tree was not scanned. That understates the
coverage that install gates and CI rely on.
This change keeps the existing behavior of not following directory symlinks
(there is an existing test asserting that skip is deliberate) but makes the
omission visible and truthful:
MultiSkillDetectionResultgainsomitted_symlink_entries, incrementedwherever a symlink (or junction/reparse point) is skipped by
detect_skills.omitted_skill_count, so it isreflected in
skills_omitted,analysis_completeness.is_complete,coverage, and the aggregate
limitations.(
skills_omitted == 1,is_complete is False, and a "symlinked recursiveskill(s) omitted" limitation).
Changes
src/skillspector/multi_skill.py: count skipped symlink entries indetect_skillsand expose them onMultiSkillDetectionResult.src/skillspector/cli.py: account foromitted_symlink_entrieswhencomputing the aggregate omitted count, completeness, and limitations, and
warn in the terminal when symlinked skill directories were skipped.
Validation summary
tests/test_multi_skill.pyfor the existingsymlink skip paths.
tests/unit/test_cli.pywithomitted_symlink_entries=1:skills_omitted == 1,is_complete is False,and the symlink limitation text is present.
requiring API keys), 4 xfailed.
make lintandmake formatclean on changed files. mypy reports onlypre-existing errors that are unchanged from
main.