Repository navigation
[None][feat] Add image routing metadata to OpenEngine KV events #21125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
krishung5
wants to merge
44
commits into
NVIDIA:main
Choose a base branch
from
krishung5:openengine-image-routing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+649
−14
Open
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
13e0e05
feat(openengine): support image inputs
krishung5 1748fb7
fix(openengine): harden multimodal media handling
krishung5 856630a
style(openengine): tighten media comments
krishung5 423d2b1
fix(openengine): harden decoded media accounting
krishung5 5d2e3b2
fix(media): prevent DNS rebinding during async fetches
krishung5 87f270c
feat(openengine): support image inputs
krishung5 d2cf114
fix(openengine): harden multimodal media handling
krishung5 1220a29
style(openengine): tighten media comments
krishung5 42d8a1c
fix(openengine): harden decoded media accounting
krishung5 14cb645
fix(media): prevent DNS rebinding during async fetches
krishung5 a3cff30
fix(openengine): address image review feedback
krishung5 9dc3ab1
Merge remote-tracking branch 'origin/main' into openengine-image-media
krishung5 dac2ab5
Merge remote-tracking branch 'fork/openengine-image-media' into opene…
krishung5 7af9e07
Merge remote-tracking branch 'origin/main' into openengine-image-media
krishung5 cfcc7b8
Merge remote-tracking branch 'origin/main' into openengine-image-media
krishung5 1e3f7f8
fix: preserve permanent media client errors
krishung5 220478b
fix(openengine): reserve request IDs before media loading
krishung5 db9a687
fix(inputs): scope shared media session to event loop
krishung5 36f4fb2
Merge remote-tracking branch 'origin/main' into openengine-image-media
krishung5 c0e8499
fix(openengine): validate and cancel multimodal request preparation
krishung5 c63d619
fix(shared-tensor): avoid global strategy races and reclaim exports
krishung5 67fb3b7
fix(openengine): own preprocessing exports and isolate media work
krishung5 bc89fc1
Merge origin/main into openengine-image-media
krishung5 53e6659
fix: resolve image OpenEngine L0 test failures
krishung5 750f17d
Merge origin/main into openengine-image-media
krishung5 af1d00b
fix: remove duplicate test request keyword after merge
krishung5 91090f5
Merge remote-tracking branch 'origin/main' into openengine-image-media
krishung5 53b9c63
Merge origin/main into openengine-image-media
krishung5 1604832
[None][feat] Publish image routing hints in OpenEngine KV events
krishung5 e637878
Merge image prerequisite into OpenEngine image routing
krishung5 3c872a4
[None][fix] Gate image routing and keep UUID metadata client-neutral
krishung5 6c15d02
Merge origin/main into openengine-image-routing
krishung5 1fffd60
[None][fix] Default multimodal processor media IO preferences
krishung5 e2b1d28
Merge origin/main after image support landed into image routing
krishung5 b882976
Merge remote-tracking branch 'origin/main' into openengine-image-routing
krishung5 d83bef8
[None][test] Fix KV-cache, ADP and mRoPE test fixtures
krishung5 756422c
[None][fix] Validate image routing UUID pairs before registration
krishung5 7495cfb
[None][fix] Preserve inference and metadata for unmapped image hints
krishung5 e6b1db5
Avoid duplicate image routing keys in KV events
krishung5 d550dcf
Merge remote-tracking branch 'origin/main' into openengine-image-routing
krishung5 bb4e1f3
Avoid repeated image hint registration during chunked prefill
krishung5 3b8f84d
Merge remote-tracking branch 'origin/main' into openengine-image-routing
krishung5 1daf67a
Narrow image routing scope and clarify event metadata docs
krishung5 3e3cc21
Merge remote-tracking branch 'origin/main' into openengine-image-routing
krishung5 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once a digest is set to
None, this branch keeps itNoneforever while the digest is live: a later registration with the original UUID compares unequal toNone, andmove_to_endbelow refreshes recency on every call, so a frequently requested image never reaches the eviction that the README promises will clear the ambiguity ("until its entry is evicted").test_streaming_uuid_hints_are_bounded_and_do_not_replace_content_hashespins this as intended, so it is a documentation mismatch rather than a crash, but it means the routers lose hints for exactly the hot images where routing pays off, until a restart. Either let agreeing registrations re-set the value (for example keep a small per-digest candidate set, or skipmove_to_endwhen the entry is alreadyNoneso it ages out), or change the README sentence to say ambiguity persists as long as the digest keeps being registered.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarified in 1daf67a: registrations refresh LRU recency even for ambiguous entries, so frequently registered digests can remain ambiguous until publisher restart. Later agreeing registrations do not clear a conflict. This documents the existing conservative behavior.