Repository navigation
[None][infra] Waive 1 failed cases for main in pre-merge 66630 - #21193
Conversation
Bug(s): 7007647 Requested by: @tburt-nv Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
|
/bot skip --comment "waive only" |
|
Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements. |
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Add test skip entry tests/integration/test_lists/waives.txt |
The waiver list now skips test_llm_partial_update_weights_qwen35_mxfp8. The entry references NVBUG 7007647. |
Priority:
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Other
Suggested labels: ci: full pre-merge approved
Suggested reviewers: xinhe-nv
Merge Risk: 
c8367
-
The requested test waiver is correctly scoped and introduces no identified merge-blocking risk.
Pre-merge checks: 
-
Check name Status Explanation Title check The title clearly identifies the infrastructure change: waiving one failed main-branch test case. It follows the required ticket and type format. Description check The description explains the waiver, identifies the skipped test, links NVBug 7007647, and states the target branch and requester. It omits the template's Test Coverage and PR Checklist sections, but … Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Description check
-
Explanation
The description explains the waiver, identifies the skipped test, links NVBug 7007647, and states the target branch and requester. It omits the template's Test Coverage and PR Checklist sections, but the core information is complete for this automated waiver.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
|
PR_Github #81193 [ skip ] triggered by Bot. Commit: |
|
PR_Github #81193 [ skip ] completed with state |
Auto-generated Waive PR
Created by: TensorRT LLM CI Report (requested by @tburt-nv)
Target branch:
mainBug(s): 7007647
Waive entries added
This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.
Dev Engineer Review
The change adds one waiver in
tests/integration/test_lists/waives.txtfortest_llm_partial_update_weights_qwen35_mxfp8, linked to NVBUG 7007647. It changes no source code or public APIs. The waiver excludes this specific test from normal test execution while it remains active.QA Engineer Review
The change modifies only
tests/integration/test_lists/waives.txt. It adds a skip entry forunittest/_torch/ray_orchestrator/multi_gpu/test_llm_update_weights_multi_gpu.py::test_llm_partial_update_weights_qwen35_mxfp8. No test result is supplied. Coverage verdict: needs follow-up because the test is waived.Per-File QA Perspective
tests/integration/test_lists/waives.txt: Adds a waiver for the named multi-GPU weight-update test. Verify the waiver is removed when the underlying failure is resolved.