Skip to content

[JAX][Fix] Gate collective-stream compute_on on import and silence pylint - #3329

Merged
phu0ngng merged 2 commits into
NVIDIA:mainfrom
phu0ngng:jax_compute_on_version
Aug 10, 2026
Merged

[JAX][Fix] Gate collective-stream compute_on on import and silence pylint#3329
phu0ngng merged 2 commits into
NVIDIA:mainfrom
phu0ngng:jax_compute_on_version

Conversation

@phu0ngng

@phu0ngng phu0ngng commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Description

Please include a brief summary of the changes, relevant motivation and context.

Fixes # (issue)

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

Please list the changes introduced in this PR:

  • Change A
  • Change B

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

…not-callable

Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
@phu0ngng

phu0ngng commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator Author

/te-ci L1 JAX

@greptile-apps

greptile-apps Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR strengthens collective-stream capability detection by requiring both the minimum JAX version and a successful compute_on import, while suppressing a false-positive pylint diagnostic.

  • Caches the collective-stream support probe and safely disables the annotation when the optional JAX API cannot be imported.
  • Documents the intentional callable use of compute_on for pylint.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
transformer_engine/jax/version_utils.py Adds a cached import-level capability check so unsupported JAX installations return false instead of failing when collective-stream support is selected.
transformer_engine/jax/cpp_extensions/ep.py Suppresses the false-positive not-callable warning without changing collective-stream runtime behavior.

Reviews (2): Last reviewed commit: "Merge branch 'main' into jax_compute_on_..." | Re-trigger Greptile

@phu0ngng
phu0ngng merged commit 32f7096 into NVIDIA:main Aug 10, 2026
9 of 14 checks passed
@phu0ngng
phu0ngng deleted the jax_compute_on_version branch August 10, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants