Repository navigation
docs(gpu-operator): Correct single and mixed MIG strategy definitions - #529
Merged
Merged
Conversation
Signed-off-by: Mike McKiernan <mmckiernan@nvidia.com> Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Documentation preview |
…ixed strategy Signed-off-by: Mike McKiernan <mmckiernan@nvidia.com> Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…ery GPU Signed-off-by: Mike McKiernan <mmckiernan@nvidia.com> Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Rajath Agasthya <rajathagasthya@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gpu-operator/gpu-operator-mig.rstdefined the MIG strategies by MIG mode (single: MIG enabled on all GPUs;mixed: MIG not enabled on all GPUs). That contradicts the same page: the "Example: Mixed MIG Strategy" section fully partitions a GPU withall-balanced, and the custom-configuration steps say to usemixedfor more than one instance profile.This PR redefines each strategy by what the device plugin and GPU Feature Discovery present to Kubernetes, and states that the strategy does not enable MIG mode. It also links once to the device plugin README
MIG_STRATEGYsection for resource and label names.Both custom MIG configuration examples now say to use
mixedwhen the configuration uses more than one MIG profile or leaves MIG mode disabled on any GPU, and state whatsinglesupports. The installation example'scustom-migconfig (manifests/input/mig-cm-values.yaml) disables MIG on GPU 0, so a sentence after the YAML points that out.The wording is backed by operand source (k8s-device-plugin
bfc6655ff, gpu-operatorff1e0171b):single—internal/rm/device_map.go:requireUniformMIGDevices = true;assertAllMigDevicesAreValid(true)errors when a MIG-enabled GPU has no MIG devices or when MIG device attributes differ ("more than one MIG device type present on node"); the build errors when full GPUs and MIG devices coexist.internal/lm/mig-strategy.gonewMigStrategySingleLabelerapplies the same rules and emits<model>-MIG-INVALIDon failure.internal/rm/rm.goAddDefaultResourcesToConfigmaps MIG devices togpu.mixed—buildGPUDeviceMapskips only MIG-enabled GPUs, so MIG-disabled GPUs remainnvidia.com/gpu; MIG devices register asmig-<profile>.applyMIGConfigurationsetsMIG_STRATEGYonly for GFD, the device plugin, and the MPS control daemon; MIG Manager does not read it.Built locally with
./repo docs -p gpu-operator -p openshift. The page renders; the only build errors are the existingtab-seterrors indra-intro-install.rstandgpu-driver-upgrades.rst. The first commit also includes trailing-whitespace fixes from the pre-commit hook on three existing lines of the same file.Link to Devin session: https://nvidia-cloud.devinenterprise.com/sessions/72ec3e92fc204828b501584860d0faad
Open in Devin Desktop: https://nvidia-cloud.devinenterprise.com/desktop/session/72ec3e92fc204828b501584860d0faad?variant=devin
Requested by: @mikemckiernan