Repository navigation
Conversation
rwagwani
force-pushed
the
fix/video-save-quality-min-1
branch
from
October 30, 2026 06:55
4ee0486 to
93b2357
Compare
…generation VideoSaveQuality accepted 0-10, but imageio-ffmpeg asserts 1 <= quality <= 10 when it writes vision.mp4. A request with video_save_quality=0 therefore loaded the model, generated the whole video, and only then failed with "quality must be between 1 and 10 inclusive". 11 and -1 were already rejected at startup. Tighten the type to ge=1 so 0 is rejected at startup like the other out-of-range values. Reasoner mode filled an inert placeholder of 0 (its output is text, so the value is never used); set it to 10 so reasoner samples still validate. Signed-off-by: rwagwani <rwagwani@nvidia.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rwagwani
force-pushed
the
fix/video-save-quality-min-1
branch
from
November 3, 2026 08:09
93b2357 to
24b4a16
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VideoSaveQualityaccepted 0-10, but imageio-ffmpeg asserts1 <= quality <= 10when it writesvision.mp4. A request withvideo_save_quality: 0loaded the model, generated the whole video, and only then failed withquality must be between 1 and 10 inclusive.11and-1were already rejected at startup.Change
VideoSaveQualitybecomesge=1, le=10, so0is rejected at startup like the other out-of-range values. The field description now says 1-10.video_save_quality = 0placeholder (its output is text, so the value is never read). It is now 10, so reasoner samples still validate. The existingtest_edge_num_frames_defaultcaught this.Behaviour change:
video_save_quality: 0is now rejected for every mode, including image modes (text2image, image2image) that never read it. No shipped spec, default or notebook uses 0 (the values in use are 4, 8 and 10).Verification
args_test.py: 67 passed.-m L0, same command asgpu-tests.yml), replicated on a single GB300: 790 passed on this branch vs 784 on main 1a2f03a. The 6 extra are the new tests. The one failure (activation_marks_test.py::test_marking_costs_less_memory_than_saving_every_eligible_op) fails the same way on main on this machine.🤖 Generated with Claude Code