Repository navigation
Conversation
Replay the reviewed Edge Reasoner cookbook onto main after the generate-media skill migration. Nano and Super stay on release:1.3.0rc22. Edge is served from TensorRT-LLM main at or after 39a44fab. Signed-off-by: Yiming Zhao <yimingz@nvidia.com>
There was a problem hiding this comment.
The shared source-build steps still pin a VisualGen commit that predates Cosmos3-Edge. Tell Edge readers to check out main at or after 39a44fab instead. Signed-off-by: Yiming Zhao <yimingz@nvidia.com>
Give Edge its own checkout of 39a44fab, and resolve the trtllm-serve interpreter from a sibling python or the command shebang. Signed-off-by: Yiming Zhao <yimingz@nvidia.com>
|
Thanks @lfengad @satishra-ai . Both items from the review are fixed in 6cf8beb. The Edge section now has its own checkout, The Edge launch cell no longer requires a I checked these paths with local stand-ins for |
pengcuo
left a comment
There was a problem hiding this comment.
Review notes (docs/notebook only; I did not run the notebook).
-
The "release images through
v1.4.0rc1" framing is stale.v1.4.0rc2was published 2026-10-28, two days before this PR, and it is 23 commits ahead of39a44fab. Itsdocs/source/models/supported-models.mdlistsCosmos3EdgeForConditionalGeneration;v1.4.0rc1does not. Edge therefore no longer needs a source build at a raw commit. I'd say "Edge requires TensorRT-LLM >= v1.4.0rc2" and, if anrc2NGC image exists, use it. Keep the commit checkout only as a fallback. I could not check NGC from here. The same text is repeated inREADME.md,reasoner/README.mdand four places in the notebook, so it needs updating in each. -
reasoner/README.mdquickstart changed for every tier. The TRT-LLM quickstart is shared by Nano, Super and Edge. This PR changes its prompt from "Caption the image in detail." to a one-sentence prompt,max_tokens4096 -> 1024, and addstemperature=0, "to match the Cosmos Framework Edge example". That makes the Nano/Super quickstart worse and is unrelated to adding Edge. I'd leave the quickstart as is, or show the Edge variant separately. -
Low: the
trtllm-serveinterpreter lookup. The ~25-line shell block that resolves the interpreter fromtrtllm-serve's shebang is copied into the README and the notebook.python -m pip install opencv-python-headlessin the same environment as the source build is what the old text said and is much simpler to maintain. If the shebang case matters, one sentence would do.
Edge no longer depends on a raw main checkout. Keep that checkout as a fallback, restore the shared Nano/Super quickstart, and install OpenCV with the container python. Signed-off-by: Yiming Zhao <yimingz@nvidia.com>
|
Thanks @pengcuo . Addressed in 6b84b7a. Edge now requires TensorRT-LLM >= v1.4.0rc2 and runs in nvcr.io/nvidia/tensorrt-llm/release:1.4.0rc2. v1.4.0rc2 lists Cosmos3EdgeForConditionalGeneration, and the NGC tag is published. v1.4.0rc1 and release:1.3.0rc22 do not include it. The 39a44fab checkout remains only as a fallback when that image is unavailable. Nano and Super stay on release:1.3.0rc22. The shared TensorRT-LLM quickstart is back to "Caption the image in detail." with max_tokens=4096. The one-sentence Edge example, max_tokens=1024 and temperature=0, is a separate note. OpenCV is installed with python -m pip install opencv-python-headless in the same environment as trtllm-serve. The shebang lookup is gone. The Edge notebook cell installs it inside the v1.4.0rc2 container, the same way Nano and Super do. |
Summary
nvcr.io/nvidia/tensorrt-llm/release:1.3.0rc22.mainbuild at or after39a44fab(the merge of [None][feat] Add Cosmos3-Edge Reasoner support TensorRT-LLM#20307). Release images throughv1.4.0rc1do not includeCosmos3EdgeForConditionalGeneration.Testing