Repository navigation
Conversation
A generated launcher compiled the kernel for whatever grid `.const_grid` was given, then inferred the launch grid separately. With `.const_grid((0, 0, 0))` the kernel was compiled for an empty grid and then launched on the grid inferred from an exact partition binding, or failed with "Launch grid required" when there was none. A grid with only some dimensions zero was also compiled first. `launcher_const_grid` now rejects a const grid with any zero dimension before anything is compiled, on the launch path (including `.compile()` warmup) and in `specialize()`. The error is the same `KernelLaunch` error the other grid checks return. Signed-off-by: Robert Deaton <me@rdeaton.space>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A generated launcher compiled the kernel for whatever grid
.const_gridwas given, then inferred the launch grid separately. With.const_grid((0, 0, 0))the kernel was compiled for an empty grid and then launched on the grid inferred from an exact partition binding, or failed with "Launch grid required" when there was none.launcher_const_gridnow rejects a const grid with any zero dimension before anything is compiled, on the launch path (including.compile()warmup) and inspecialize(). The error is the sameKernelLauncherror the other grid checks return.Changes
Testing
Checklist
git commit -s)