Skip to content

Revert "Stop defaulting deprecated cdi.default in ClusterPolicy" #2865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tariq1890 wants to merge 1 commit into from
Closed

Revert "Stop defaulting deprecated cdi.default in ClusterPolicy" #2865

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions api/nvidia/v1/clusterpolicy_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1967,6 +1967,7 @@ type CDIConfigSpec struct {

// Deprecated: This field is no longer used. Setting cdi.enabled=true will configure CDI as the default mechanism for making GPUs accessible to containers.
// +kubebuilder:validation:Optional
// +kubebuilder:default=false

@coderabbitai coderabbitai Bot Sep 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Regenerate and justify this released CRD change before merging.

Line 1970 changes the default for an existing ClusterPolicy field. After the generated CRD is applied, requests that omit spec.cdi.default can persist false. The deprecated field is not used by CDIConfigSpec.IsEnabled(), so this can change stored objects and ArgoCD diffs without changing CDI runtime behavior.

The cohort includes only api/nvidia/v1/clusterpolicy_types.go. Regenerate and commit the CRD assets and deepcopy output required by this API-type change. Document why the changed default is safe for already-applied ClusterPolicy resources.

As per path instructions, api/**/*.go contains released CRDs; changed +kubebuilder:default values are major API changes, and editing these types requires regenerated deepcopy and CRD assets.

Source: Path instructions

// +operator-sdk:gen-csv:customresourcedefinitions.specDescriptors=true
// +operator-sdk:gen-csv:customresourcedefinitions.specDescriptors.displayName="Deprecated: This field is no longer used"
// +operator-sdk:gen-csv:customresourcedefinitions.specDescriptors.x-descriptors="urn:alm:descriptor:com.tectonic.ui:booleanSwitch,urn:alm:descriptor:com.tectonic.ui:hidden"
Expand Down
1 change: 1 addition & 0 deletions bundle/manifests/nvidia.com_clusterpolicies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ spec:
used in the cluster
properties:
default:
default: false
description: 'Deprecated: This field is no longer used. Setting
cdi.enabled=true will configure CDI as the default mechanism
for making GPUs accessible to containers.'
Expand Down
1 change: 1 addition & 0 deletions config/crd/bases/nvidia.com_clusterpolicies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ spec:
used in the cluster
properties:
default:
default: false
description: 'Deprecated: This field is no longer used. Setting
cdi.enabled=true will configure CDI as the default mechanism
for making GPUs accessible to containers.'
Expand Down
1 change: 1 addition & 0 deletions deployments/gpu-operator/crds/nvidia.com_clusterpolicies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ spec:
used in the cluster
properties:
default:
default: false
description: 'Deprecated: This field is no longer used. Setting
cdi.enabled=true will configure CDI as the default mechanism
for making GPUs accessible to containers.'
Expand Down
Loading