patch(v2.1): recognize hyphenated BlueField-3 DPU models - #5593
Conversation
Backport NVIDIA#4829 to release/v2.1. Reuse the shared DpuModel parser when identifying DPUs so Redfish chassis models such as "BlueField-3 DPU" classify as BlueField3. This lets the BF3 BMC eth0 PF0 MAC fallback run when the system-image MAC is unavailable and changes model() from "unknown" to "bluefield3". Cover both BF3 spellings, BF2 and unknown models, the BF3 topology guard, and PF MAC derivation. The process-local site-explorer integration executable was not run locally and remains covered by CI. (cherry picked from commit 5b919eb)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🔐 TruffleHog Secret Scan✅ No secrets or credentials found! Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉 🕐 Last updated: 2026-08-31 20:53:08 UTC | Commit: fd90955 |
nv-dmendoza
left a comment
nv-dmendoza
left a comment
There was a problem hiding this comment.
LGTM, backports fix
2 participants
Redfish reports from affected BF3 cards use the chassis model
BlueField-3 DPU.release/v2.1only recognizes the space-separated form, so these reports are classified asUnknownand cannot use the BF3 BMCeth0PF0 MAC fallback when the system-image MAC is unavailable.This backport:
DpuModelparser, which normalizes hyphens.EndpointExplorationReport::model()for affected reports fromunknowntobluefield3.Related issues
Type of Change
Breaking Changes
Testing
Validation completed in a local Linux/arm64 Docker environment:
cargo test --locked -p carbide-api-model identify_dpu— passed.cargo test --locked -p carbide-api-model -p carbide-site-explorer --lib— passed with PostgreSQL.cargo test --locked -p carbide-firmware --lib— passed with PostgreSQL.cargo clippy --locked -p carbide-api-model -p carbide-site-explorer --all-targets— passed.cargo fmt --check— passed; existing warnings for nightly-only formatter settings were emitted.Additional Notes
The code patch is identical to #4829. The process-local SQLx site-explorer integration executable was not run locally; CI provides that integration coverage.