Repository navigation
Conversation
Errors, docstrings, doctests, install hints and the demo notebook told kumo-engine users to call kumoai_studio functions or install kumoai-studio. Reword them library-neutrally and show the kumo.engine API where an example is needed. No behaviour change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
Change map
|
Contributor
Author
|
Closing: out of scope. kumoai_studio is still the right reference for the hosted SDK, and these shared modules serve both. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes text that tells kumo-engine users to use the hosted service SDK (
kumoai_studio/kumoai-studio).Problem
kumo-engine runs everything in-process and has no dependency on the hosted SDK, but several messages and docs it surfaces pointed users there. For example, a connector naming an identity that does not exist raised:
A kumo-engine user cannot follow that advice. The same pattern appeared in the duplicate-identity error, connector reader docstrings and doctests (
import kumoai_studio as kumo,kumo.LocalBackend), install hints (pip install 'kumoai-studio[s3]'), thekumo.engineconnector module docs ("mirrors the cloud SDK'skumoai.connector..."), the demo notebook, and thekumo-apiREADME.Change
Most of these modules are shared with the hosted SDK, so the text is now library-neutral. Where an example is needed it uses the kumo-engine API (
import kumo.engine as kumo,SnowflakeConnector(..., identity=SnowflakeIdentity(...))). The same error now reads:Files:
kumo-core:sources/principals.py(two error messages)kumo-{snowflake,databricks,bigquery,gcs,s3}backend.py,kumo-snowflakespcs.py(docstrings, doctests, install hints)kumo-engine:connector/{base,bigquery,databricks,gcs,s3,source_table}.py,config.py,_infer.py,_portable.py(module docs),notebooks/demo_netflix_gnn.ipynbkumo-api/README.mdNo behaviour change: only message text, docstrings, skipped doctests and markdown change.
Files changed by the open MLOps PRs (#50–#115) are left for a follow-up to avoid conflicts, including
kumo_snowflake/artifacts.py,registry.py,sink.py,kumo_databricks/sink.pyandkumo/engine/__init__.py.Testing Done
kumo-coretests/sources/unit/test_principals.py,test_identity.py: 24 passedkumo-snowflaketests/test_spcs.py,test_package_boundary.py,test_identity.py,test_backend.py: 30 passedkumo-enginetest/test_snowflake_connector.py: 7 passed🤖 Generated with Claude Code