Repository navigation
Ship the agent skill in the kumo-engine wheel: kumo.engine.install_skills() #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
23802ec
14a51ec
8caea0e
5a15087
7ed8896
76cd6f7
feefa6d
ad5d748
e6df3db
923874f
7d9829c
05c018d
13f002d
e35d691
b7a391d
b5d5245
f0a5b31
f163844
79d5f45
bac10d9
e1ce213
d1cf34e
d4e2c81
86a1ba8
5ba5655
4f974c5
f8cc57d
10b5dc8
9cd96a0
366657f
e9cae49
bcb835b
f36b89b
d21ec19
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| --- | ||
| name: skill-zips | ||
| description: Check, or rebuild and attach, the kumo-data-science agent skill zips on a kumo-engine GitHub release. | ||
| --- | ||
|
|
||
| # Skill zips | ||
|
|
||
| Every `kumo-engine-v<version>` release carries one agent skill zip per host, attached by the | ||
| `skill-zips` job in `.github/workflows/kumo-engine-wheel.yml`: | ||
| `kumo-data-science-coco.zip`, `kumo-data-science-generic.zip`, `kumo-data-science-genie.zip`. | ||
| The docs download button and install scripts link to them by tag. Use this skill to confirm a | ||
| release's zips are there and correct, or to attach them when the job did not. | ||
|
|
||
| Argument: the version, e.g. `1.1.0`. The tag is `kumo-engine-v<version>`. | ||
|
|
||
| ## Steps | ||
|
|
||
| 1. List the release's assets: | ||
| `gh release view kumo-engine-v<version> -R NVIDIA/kumo-engine --json assets --jq '.assets[].name'` | ||
|
|
||
| 2. Rebuild the zips from the tag, in a scratch worktree so no local edit leaks into the build: | ||
| ```bash | ||
| git fetch origin tag kumo-engine-v<version> | ||
| git worktree add --detach <scratch>/tag kumo-engine-v<version> | ||
| python3 <scratch>/tag/agent-skills/scripts/package_skill.py --zip <scratch>/built | ||
| ``` | ||
| The tag must carry `package_skill.py --zip`. A release cut before it has no skill zips and | ||
| cannot be given any this way; say so and stop. | ||
|
|
||
| 3. If the release has all three zips, download them into a new empty directory | ||
| (`gh release download kumo-engine-v<version> -R NVIDIA/kumo-engine -p 'kumo-data-science-*.zip' -D <scratch>/released`) | ||
| and compare each with its rebuild (`cmp`). The build is reproducible, so any difference means | ||
| the attached zip was not built from the tag. Report the result, with the `SKILL-BUILD` line from | ||
| each zip's `kumo-data-science/SKILL.md`. | ||
|
|
||
| 4. If any zip is missing, show the user the rebuilt zips (file counts, `SKILL-BUILD`) and **ask | ||
| before uploading**: attaching to a public release publishes the files. On approval: | ||
| `gh release upload kumo-engine-v<version> -R NVIDIA/kumo-engine <scratch>/built/*.zip` | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Upload only the missing ZIPs. If a release already has one or two ZIPs, this glob also selects those existing assets. |
||
| Never pass `--clobber` over a zip that step 3 found to differ without telling the user first. | ||
|
|
||
| 5. Remove the scratch worktree: `git worktree remove <scratch>/tag`. | ||
|
|
||
| Never upload zips built from a branch, or from a checkout with local changes: the zip must be the | ||
| skill built from the release's own commit, as the wheel's copy is. | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fetch the tag from the release repository.
If
originis a fork that lacks the release tag, this step fails. If the fork has a different commit under that tag, the command can publish the fork’s skill to the NVIDIA release after approval. Fetch the tag fromNVIDIA/kumo-engineand build its resolved commit. (git-scm.com)