Repository navigation
Separate public CI from private resource tests - #42
aaron-kumo wants to merge 4 commits into
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Change mapFork PR jobs currently attempt cloud authentication before tests can run. Separate public tests from resource-backed suites, and reuse copy-pr-bot approval for private CI and OpenAPI analysis.
Verification: 20 Node tests, six selector/driver regressions, the fixture-provisioning regression, and OpenAPI generation passed locally. Workflow security and documentation checks passed; workflow lint has no new findings. Live provider results and the 25-minute CI target remain unverified. Stopping condition: public and approved private CI pass on the current head, with no unexpected credential skips. Remove temporary phase instrumentation after S3 profiling. |
b1d5f3f to
7d5320a
Compare
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
64adae8 to
5369bc0
Compare
|
I am also working on this PR that separates cloud test from the original main CI so fork PRs only run public tests. #39 (in progress). I think PR#42 can supersede PR#39 so I will close my PR. |
|
/ok to test 5369bc0 |
|
Hey @anle2024 , sorry, I didn't notice you have an existing PR targeted at this problem. I agree this PR supersedes it- for immediate unblock of @haoweiyu-kumo 's PR he updated it to not use a fork repository branch as that's not needed, but fork PR support will be needed when we start accepting 3p contributions. At that point we want to make sure CI can properly run for their PRs too (after we approve the CI to run, tests using our private creds should utilize NVIDIA private runners). |
That makes sense. I was also planning to work on the broader fork PR workflow and private CI setup, but held off after yesterday’s discussion since we are not targeting third-party contributions yet for this week. If we need this to unblock current work, I agree it makes sense to move ahead now. |
5369bc0 to
8b24cd4
Compare
|
/ok to test 8b24cd4 |
The artifact name is set by a step that runs only if every earlier step passed. After an earlier failure, the upload ran with an empty name and failed with "Input required and not supplied: path", adding a second error to the job. Co-Authored-By: Claude <noreply@anthropic.com> (cherry picked from commit 3411cb2)
Analyze OpenAPI schemas on approved copied PR branches, publish schema patches, and update PR comments after checking the current head. Share copied-PR validation and local merge-base selection with private CI, and document the required CI configuration. Adapt the merge-base approach from Vedaant Jain's commit 2c6ddfc. Co-authored-by: Vedaant Jain <vedaantj@nvidia.com>
What
Why
Allow third-party PRs to run public CI without private credentials, then run resource-backed tests and OpenAPI checks after SHA approval.
Incorporates the coverage-upload fix and adapts the merge-base approach from #142.
Validation
Local regressions, workflow security checks, and OpenAPI generation passed. Workflow lint has no new findings. Live provider validation remains pending.
Change map