fix(pylon): derive fallback throughput from observed requests - #1457
Open
barrygreengus wants to merge 11 commits into
Open
fix(pylon): derive fallback throughput from observed requests#1457barrygreengus wants to merge 11 commits into
barrygreengus wants to merge 11 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
barrygreengus
force-pushed
the
codex/pylon-mode-off-throughput
branch
from
September 2, 2026 01:52
5bc1ff3 to
2ceda51
Compare
Signed-off-by: Barry Greengus <bgreengus@nvidia.com>
Signed-off-by: Barry Greengus <bgreengus@nvidia.com>
Signed-off-by: Barry Greengus <bgreengus@nvidia.com>
Signed-off-by: Barry Greengus <bgreengus@nvidia.com>
Signed-off-by: Barry Greengus <bgreengus@nvidia.com>
Signed-off-by: Barry Greengus <bgreengus@nvidia.com>
Signed-off-by: Barry Greengus <bgreengus@nvidia.com>
Signed-off-by: Barry Greengus <bgreengus@nvidia.com>
Signed-off-by: Barry Greengus <bgreengus@nvidia.com>
Signed-off-by: Barry Greengus <bgreengus@nvidia.com>
barrygreengus
force-pushed
the
codex/pylon-mode-off-stats-plan
branch
from
September 2, 2026 03:04
78ab652 to
eace2ce
Compare
barrygreengus
force-pushed
the
codex/pylon-mode-off-throughput
branch
from
September 2, 2026 03:04
2ceda51 to
18dd2ed
Compare
Signed-off-by: Barry Greengus <bgreengus@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Pylon deployments with
--engine-stats-stream offdo not receive authoritative engine statistics. Without a request-derived fallback, request load remains on bootstrap values and output throughput cannot reliably use observed or exact usage.This throughput slice is stacked on #1452 and uses the shared-cluster statistics contract from #1448.
What changed
PylonRuntimeState::observe_requestAPI.--force-chat-completions-include-usageoption for direct and reverse Pylon modes.request.load.proxy_localeven when current request load is zero.Customer Release Notes
Pylon can derive input and output throughput from observed requests when the engine statistics stream is disabled. Operators can also opt in to exact streaming Chat Completions usage requests.
Plan Summary
No infrastructure or resource changes.
Deployment order:
Usage
Enable exact streaming Chat Completions usage requests with:
The option defaults to disabled.
Testing
cargo test -p pylon-lib: 448 unit tests and 4 public API tests passed on this branch.cargo test -p pylon: 67 unit tests and 1 CLI test passed on this branch.cargo clippy -p pylon-lib -p pylon --all-targets -- -D warnings: passed.cargo test --workspacepassed 1,545 tests with 3 ignored.cargo test -p stargatepassed 571 tests.No separate QA environment is required for this code-only slice. The unchanged Pylon library Criterion benchmark target was not run under
--all-targetsbecause it exceeds the local test timeout.Notes
The rewrite worker limit applies only to CPU work. Slow request uploads do not reserve worker capacity. Each body remains independently bounded by the existing request-body limit.
Full-workspace
cargo fmt --all -- --checkreports only four inherited formatting differences in unchanged Stargate files:crates/stargate/src/http_proxy.rs,crates/stargate/src/main.rs,crates/stargate/src/runtime.rs, andcrates/stargate/tests/suite/health_lifecycle.rs. Every changed Rust file passes formatting checks.No dependency, license, NOTICE, protobuf, generated-file, metric-name, span-name, dashboard, or alert changes are included.
Issues
Relates to #1447
References
Related Pull Requests
Dependencies
None. No license review or NOTICE update is required.