fix(worker-utils): bump the worker library pin so the transport rotation ships - #1496
Open
balajinvda wants to merge 1 commit into
Open
fix(worker-utils): bump the worker library pin so the transport rotation ships#1496balajinvda wants to merge 1 commit into
balajinvda wants to merge 1 commit into
Conversation
…ion ships
The four worker services consume src/libraries/go/worker as a pinned
pseudo-version, not as local source, and that pin has been at a 10 July commit:
v0.0.0-20260710034659-973443ac16c3
So every worker image built since then excludes anything merged into the
library, including the QUIC transport rotation from #1383. Verified rather than
assumed: two dev images built from different commits, one of which contained
#1383, had identical digests, and extracting the layers showed the rotation
strings absent while the surrounding proxy code was present.
gh.1136-748ba8d1 sha256:5a0a158a... 'rotating quic transport' 0
gh.1182-ce91506b sha256:5a0a158a... 'rotating quic transport' 0
'failed to dial host' 1 (control)
Deploying either would have shown no improvement and looked like the fix
failing, when the fix was never in the binary.
Bumping to a commit that contains it fixes that. Confirmed by building
worker-utils locally against the new pin and grepping the compiled archive:
proxy.a 'rotating quic transport' 2
'consecutive dial failures' 2
'failed to dial host' 2 (control)
The module proxy serves the new pseudo-version, so CI needs no special
resolution. Local `go get` did need GOPRIVATE, because the proxy will not
resolve the nested module path by SHA without it; that is a workstation
concern, not a build dependency.
All four consumers are bumped together. Leaving any behind would produce images
that disagree about the library version.
Co-Authored-By: Balaji Ganesan <bganesan@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (4)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe pull request updates the worker library dependency in four compute-plane Go modules from the July 2026 pseudo-version to the September 2026 pseudo-version. ChangesWorker dependency alignment
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This change updates all four worker services to the library revision containing the transport fix, with matching checksum updates. No actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Relates to #1382
Why
The four worker services consume
src/libraries/go/workeras a pinned pseudo-version, not as local source:That pin is from 10 July, so every worker image built since then excludes anything merged into the library — including the QUIC transport rotation from #1383.
This was verified, not assumed. Two dev images built from different commits, one containing #1383, came out with identical digests:
Extracting the layers and grepping the binary:
Deploying either image would have shown the failure unchanged and read as the fix not working, when it was never compiled in.
What changed
The pin moves to a commit containing #1383, in all four consumers plus their
go.sum:All four are bumped together on purpose. Leaving any behind produces images that disagree about the library version.
Customer Release Notes
Not customer visible on its own. It is what allows the worker-side fix in #1383 to reach a built image.
Plan Summary
Not applicable.
Usage
Verify any worker image before drawing conclusions from a deploy:
Testing
Built
//src/compute-plane-services/worker-utils/worker:workeragainst the new pin and grepped the compiled archive:Before the bump the first two were zero in the shipped image.
The module proxy serves the new pseudo-version (
200for the.infoendpoint), so CI needs no special resolution. Localgo getrequiredGOPRIVATEbecause the proxy will not resolve the nested module path by SHA without it, but that is a workstation concern and not a build dependency.Notes
The pin is a recurring trap: it is silent, and the failure mode is a build that succeeds and produces an image identical to the previous one. Worth considering whether these services should consume the library through the workspace instead, so library changes cannot be silently excluded. Not attempted here.
References
None
Related Pull Requests
#1383 is the rotation this makes shippable. #1492 adds diagnostics for it and is not included in this pin.
Dependencies
No new third-party dependencies. Only the in-repo library pin and the corresponding
go.sumentries change.Summary by CodeRabbit