Repository navigation
Handle all requests when the NVIDIA driver is unloaded - #2185
Open
efegokdemir wants to merge 1 commit into
Open
efegokdemir wants to merge 1 commit into
efegokdemir wants to merge 1 commit into
Conversation
Signed-off-by: Efe Gökdemir <gokdemirefe1903@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Requests for
nonecurrently initialise NVML before returning an empty CDI device. Requests forallfail when NVML returnsERROR_DRIVER_NOT_LOADED, even though no NVIDIA devices are available. Return the empty device fornonewithout initialising NVML, and forallonly for that specific error; other NVML initialisation errors remain visible. Fixes #2163.Checklist
make test)make lint)Testing
make build— passed.make test— passed.make fmt— passed.golangci-lint run ./pkg/nvcdi,golangci-lint run --new-from-rev=HEAD~1 ./..., andgo vet ./pkg/nvcdi— passed.make lint— failed on six existingSA4023findings in unchanged code outside this change.git diff --check— passed.