Repository navigation
Conversation
A Snowflake session the client opens names itself nvidia/kumo-sdm when nothing else names it, so Snowflake can attribute its queries. This was reviewed as #50, which merged into another pull request's branch rather than main; it lands here on its own. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Manush Murali <manushm@nvidia.com>
…tion With no arguments, or only a connections file, the driver replaces what it was given with the default connection's parameters, which drops the SF_PARTNER or Streamlit name it had just detected. The session was then named nvidia/kumo-sdm. The driver's detection is now asked again before that name is used. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Manush Murali <manushm@nvidia.com>
JGagacheva
approved these changes
Oct 26, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Snowflake attributes a session's queries by the application the session names at login. Sessions the client opened named none, so they showed up as the driver's default.
Each Snowflake session the client opens now names itself
nvidia/kumo-sdmwhen nothing else names it.This was reviewed as #50, which merged into #51's branch rather than
main. #51 has reverted it, and it lands here on its own, with one fix from review since._NamedConnectionsubclasses the driver'sSnowflakeConnectionand addsapplicationinconnect. The driver first callsconnectonce it has merged three things:connections.tomlprofile, read from the caller'sconnections_file_pathif one is given;SF_PARTNER, Streamlit, Jupyter and Snowflake notebooks.applicationargument, one in the profile,SF_PARTNER, or one of the driver's notebook tags.connections_file_path, the driver replaces what it was given with the default connection's parameters, which drops the name it had just detected. The session was then namednvidia/kumo-sdmunder Streamlit orSF_PARTNER._NamedConnectionnow asks the driver's detection again before using its own name (e6e8992).Tests
test_snowflake_names_a_session_only_where_nothing_else_doesruns the driver's real resolution (snowflake-connector-python 4.8.0) over a realconnections.toml, and stops at login. Its cases:nvidia/kumo-sdmapplication='theirs'theirsSF_PARTNERsetstreamlitapplicationnvidia/kumo-sdmconnections_file_pathnvidia/kumo-sdmconnections_file_path,SF_PARTNERsetnvidia/kumo-sdmstreamlitWhat the cases catch:
main's backend, six fail: the four that should getnvidia/kumo-sdm, and the two where the driver drops the name it detected.Locally, the connectors suite passes (309 passed, 9 skipped), with ruff, ruff format, mypy and the hygiene check clean.
🤖 Generated with Claude Code