Skip to content

Fixes memory pool and minor undefined behavior and memory leaks - #148

Merged
ajaypanyala merged 6 commits into
NWChemEx:mainfrom
dmejiar:bug_fixes
Oct 13, 2026
Merged

ajaypanyala merged 6 commits into
NWChemEx:mainfrom
dmejiar:bug_fixes

Conversation

@dmejiar

@dmejiar dmejiar commented Oct 13, 2026

Copy link
Copy Markdown
Collaborator

Description

  • Divides max_host_bytes by the number of ranks per node when LIBNUMA is disabled. This avoids requesting a memory pool > 100% of the available memory with many ranks per node.
  • Removes the reference to an unused distribution that can lead to an undefined behavior warning with UBSan
  • Avoids declaring a zero-dimensional array flagged as undefined behavior with UBSan
  • flush_and_sync() deletes the manager from orphaned tensors (flagged as a memory leak by ASan)
  • Fixed the ownership cycle in TiledIndexSpace (flagged as a memory leak by ASan)

@CLAassistant

CLAassistant commented Oct 13, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@ajaypanyala
ajaypanyala merged commit 1a55941 into NWChemEx:main Oct 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants