Repository navigation
fix(rooms): let portal schedule rooms under non-project groups - #50
Merged
Merged
Conversation
The Monday lab meeting books its room under the GitLab group lab-meeting, which is not a Keycloak project group, so schedule_room refused it with 沒有這個專案群組 and the 11-09 lab meeting has no room. A trusted service caller now skips the project-group check; members are still checked. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
portal books the Monday lab meeting under the GitLab group
lab-meeting. It is not a Keycloak project group, soschedule_roomthrew沒有這個專案群組. The 2026-11-09 lab meeting has no room (portal requestroom-booking-aa536b347684, failed 11-02). The 11-02 meeting was booked before the check existed.Change
checkGroupskips the check whenactor.serviceis set (a caller with aSERVICE_KEYSkey, i.e. portal). Members, through the web or MCP, are still limited to project groups.Verification
typecheck, lint, format and actions checks pass on the sandbox. After deploy, portal retries the 11-09 booking and gets a room.
🤖 Generated with Claude Code