Skip to content

fix(smoke): make the absence checks fail the run #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zyx1121 merged 1 commit into from
Nov 3, 2026
Merged

fix(smoke): make the absence checks fail the run #99

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions deploy/smoke.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
# loaded as ghcr.io/nycu-winlab/ui:ci.
set -euo pipefail
trap 'docker compose logs' EXIT
# A negated test (! cmd) never trips set -e, so absence is checked here.
absent() { if grep -qiF "$1"; then echo "unexpected $1 in $2" >&2; exit 1; fi; }

printf 'UI_VERSION=ci\n' > .env
docker compose up -d --no-build --wait
Expand All @@ -18,18 +20,18 @@ curl -s localhost:8080/missing | grep -q '找不到這個頁面'
test "$(curl -s -o /dev/null -w '%{http_code}' localhost:8080/404)" = 404
test "$(curl -s -o /dev/null -w '%{http_code}' localhost:8080/404.html)" = 404
curl -s localhost:8080/404 | grep -q '找不到這個頁面'
! curl -sI localhost:8080/ | grep -qi "server: nginx/"
curl -sI localhost:8080/ | absent "server: nginx/" headers

# Not a sha- version: the corner reads dev, and no placeholder is left.
curl -sf localhost:8080/ | grep -q '>dev<'
! curl -sf localhost:8080/ | grep -q __BUILD_SHA__
curl -sf localhost:8080/ | absent __BUILD_SHA__ /

# A release: the corner reads the commit, in the page and in its scripts.
docker compose run --rm -d -e UI_VERSION=sha-abc1234 -p 127.0.0.1:8081:8080 web >/dev/null
for i in $(seq 1 20); do curl -sf localhost:8081/ >/dev/null && break; sleep 0.5; done
curl -sf localhost:8081/ | grep -q '>abc1234<'
! curl -sf localhost:8081/ | grep -q __BUILD_SHA__
curl -sf localhost:8081/ | absent __BUILD_SHA__ /
for js in $(curl -sf localhost:8081/ | grep -o '/_next/static/[^"]*\.js' | sort -u); do
! curl -sf "localhost:8081$js" | grep -q __BUILD_SHA__
curl -sf "localhost:8081$js" | absent __BUILD_SHA__ "$js"
done
echo "smoke passed"
Loading