Skip to content

fix(react-native/ios): attach a recycled NativeScriptUIView's handle when it matches its last one #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ammarahm-ed merged 1 commit into from
Oct 25, 2026
Merged

fix(react-native/ios): attach a recycled NativeScriptUIView's handle when it matches its last one #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions packages/react-native/ios/Fabric/NativeScriptUIViewComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@

using namespace facebook::react;

static const std::shared_ptr<const NativeScriptUIViewProps>& NativeScriptUIViewDefaultProps() {
static const auto defaultProps = std::make_shared<const NativeScriptUIViewProps>();
return defaultProps;
}

static BOOL NativeScriptFabricViewIsDescendantOfView(UIView* view, UIView* ancestor) {
UIView* current = view;
while (current != nil) {
Expand Down Expand Up @@ -78,8 +83,7 @@ @implementation NativeScriptUIViewComponentView {

- (instancetype)initWithFrame:(CGRect)frame {
if (self = [super initWithFrame:frame]) {
static const auto defaultProps = std::make_shared<const NativeScriptUIViewProps>();
_props = defaultProps;
_props = NativeScriptUIViewDefaultProps();

_containerView = [[NativeScriptUIView alloc] initWithFrame:self.bounds];
_containerView.hostReadyDelegate = self;
Expand Down Expand Up @@ -190,7 +194,12 @@ - (UIView*)hitTest:(CGPoint)point withEvent:(UIEvent*)event {
}

- (void)updateProps:(Props::Shared const&)props oldProps:(Props::Shared const&)oldProps {
const auto oldViewProps = std::static_pointer_cast<const NativeScriptUIViewProps>(_props);
// Diff against oldProps, not _props: React Native leaves _props untouched on
// recycle, while prepareForRecycle clears the container, so a recycled view
// mounted with its previous handle would otherwise never attach it.
const auto oldViewProps =
oldProps ? std::static_pointer_cast<const NativeScriptUIViewProps>(oldProps)
: NativeScriptUIViewDefaultProps();
const auto newViewProps = std::static_pointer_cast<const NativeScriptUIViewProps>(props);
const std::string oldNativeViewHandle = oldViewProps->nativeViewHandle;
const std::string newNativeViewHandle = newViewProps->nativeViewHandle;
Expand Down
Loading