Repository navigation
fix(release): build Linux and Windows binaries, publish release notes - #24
Merged
Merged
Conversation
…a tag Both v0.1.0 and v0.2.0 shipped with only the macOS binaries: - Linux musl failed in openssl-sys (reqwest's default TLS needs OpenSSL, which the runner has no musl build of). Build the glibc target instead. - Windows failed with LNK2038: esaxx-rs (via tokenizers) always uses the static CRT while mimalloc used the dynamic one. Build with +crt-static. Add a workflow_dispatch trigger with a tag input so the missing binaries can be attached to an existing release without moving its tag. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QsuMoxNk88vZYnxPepuUKV
Add the v0.2.0 notes and a release-notes job that sets the GitHub release body from that file. On a manual run it reads the notes from main, so notes can be added after a tag is cut. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QsuMoxNk88vZYnxPepuUKV
New1Direction
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by dusk · project thread
Before: the v0.2.0 release (and v0.1.0 before it) only got the two macOS binaries and has an empty description. The Linux job failed in
openssl-sys(no musl OpenSSL for reqwest's default TLS) and the Windows job failed to link with LNK2038 (esaxx-rsfrom tokenizers always uses the static CRT, mimalloc used the dynamic one). See run 37283526999.After: Linux builds the glibc target and Windows builds with
+crt-static, so all four binaries should attach. A newrelease-notesjob sets the release body from.github/release-notes/<tag>.md, and this PR adds the v0.2.0 notes. A manual trigger takes a tag, so v0.2.0 can get its missing binaries and notes without moving the tag.How: edits to
.github/workflows/release.ymlplus the notes file. On a manual run, the build jobs check out and upload to thetaginput, and the notes job reads its file from main. On a tag push everything falls back to the pushed ref, as before. The Windows fix is the standard one for this tokenizers/mimalloc CRT mismatch. I couldn't run a Windows build locally, so the real check is the manual run after merge.🤖 Generated with Claude Code
https://claude.ai/code/session_01QsuMoxNk88vZYnxPepuUKV