fix(evm): describe the spill region with module flags - #690
Merged
Merged
Conversation
Coverage Summary
|
abinavpp
force-pushed
the
app-spill-region-flags-solc
branch
from
September 25, 2026 14:34
7ac7379 to
ddee470
Compare
hedgar2017
requested changes
Sep 28, 2026
hedgar2017
left a comment
hedgar2017
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Will merge after bumping solx-llvm and inkwell.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The developer guide still documents the obsolete spill-region LLVM options as automatically configured.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Migrates EVM spill-region configuration from process-global LLVM options to per-module flags.
Changes:
- Adds memory-guard and spill-size module flags.
- Simplifies target-machine construction.
- Updates the pinned inkwell revision.
| File | Description |
|---|---|
solx-codegen-evm/src/target_machine.rs |
Removes spill-region CLI argument injection. |
solx-codegen-evm/src/codegen/context/mod.rs |
Sets spill-region module flags before optimization. |
Cargo.toml |
Updates the inkwell revision. |
Cargo.lock |
Locks the updated inkwell dependencies. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
hedgar2017
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy of #653 for
main-solc.