docs(slang): frontend design law and review skill - #700
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The documented fixture rule conflicts with the suite, and the skill does not implement its promised ambiguity handling.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Documents Slang frontend conventions and adds a read-only review skill enforcing them.
Changes:
- Expands Slang build, test, and LIT guidance.
- Defines frontend design laws and PR conventions.
- Adds and tracks the review skill.
File summaries
| File | Description |
|---|---|
CLAUDE.md |
Adds Slang workflows and design rules. |
.gitignore |
Allows Claude skills to be tracked. |
.claude/skills/review/SKILL.md |
Defines the read-only review process. |
Review details
- Files reviewed: 2/3 changed files
- Comments generated: 3
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
hedgar2017
force-pushed
the
az-slang-conventions
branch
4 times, most recently
from
September 10, 2026 10:49
44138ea to
3fa2cf6
Compare
Coverage Summary
|
hedgar2017
force-pushed
the
az-slang-conventions
branch
6 times, most recently
from
September 10, 2026 13:35
4834342 to
015271e
Compare
hedgar2017
requested review from
ChristopherDedominici,
abinavpp and
nebasuke
September 10, 2026 13:35
hedgar2017
force-pushed
the
az-slang-conventions
branch
2 times, most recently
from
September 10, 2026 13:48
f701ce4 to
b6c4c55
Compare
Records the Slang frontend's design law in CLAUDE.md and adds a read-only review skill that reviews a change against it. The skill puts every ambiguity to the user as a question and applies nothing itself.
hedgar2017
force-pushed
the
az-slang-conventions
branch
from
September 10, 2026 13:51
b6c4c55 to
c82abea
Compare
nebasuke
reviewed
Sep 13, 2026
nebasuke
reviewed
Sep 13, 2026
nebasuke
reviewed
Sep 13, 2026
Adds a posting step to the review skill: one comment per finding on the line it is about, anchored inside a diff hunk, and a review body for the findings that have no line. The report goes up only when the user asks, and the verdict stays with the user.
Answers the review of #700. The frontend's design law now sits directly under Architecture, with the build, test and pull request mechanics below it, and the CI labels and the Renovate validator check are back as prose. The review skill cites the rule each finding rests on, prompts with a fixed set of options under any harness, and splits posting into inline comments and the review comment. The README names the suites the tester runs and the ones that are planned, and the missing_docs_in_private_items lint is dropped.
ChristopherDedominici
approved these changes
Sep 14, 2026
ChristopherDedominici
left a comment
ChristopherDedominici
left a comment
There was a problem hiding this comment.
I reviewed only the skill since it's the only file where I have context. Looks good to me.
One point we might want to talk about is making this skill generic for all the Nomic teams. The skill itself is already generic. The "problem" we'll need to fix is having every team define all the rules needed for reviewing files in CLAUDE.md (or providing into it links to references with this info).
abinavpp
approved these changes
Sep 15, 2026
nebasuke
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Records the Slang frontend's design law and adds a read-only review skill that reviews a change against it.