Repository navigation
fix: mark devices crDroid has dropped as discontinued - #22
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
Bugfix (the data kind)
Overview
When crDroid drops a device it blanks the maintainer in that device's OTA file and leaves the last build where it is. The importer only looked at how old the build was, so 42 devices crDroid has given up on still listed it as a current ROM - the Galaxy A51 page, for one, called it supported off a build from August. Now a row only counts as active if there's a maintainer as well as a build from the last 180 days, which is how the LineageOS importer already treats an empty maintainer list.
crdroid.ymlis regenerated here too, with--force. Those 42 rows take crDroid from 122 active down to 80, and that trips the importer's 80% guard, so without a fresh baseline every weekly import after this one would skip crDroid. Only the 42 statuses change.Issue Number
None
Additional Info
I went by the upstream commit messages ("drop outdated devices", "drop support for larry" and so on) and spot checked a handful of devices, not all 42.
Some AI was use when making this