Conversation
NobodyXu
reviewed
Oct 2, 2026
NobodyXu
left a comment
Collaborator
There was a problem hiding this comment.
This is awesome!
However I don't think we need to bump it, just a cargo update on projects using our crate is good enough?
Contributor
Author
|
Yep, you're right. I can close this PR. It's really just a minimum version bump |
Collaborator
|
Thank you! Happy to take a major version bump or a bugfix/new API to be used bump |
Collaborator
|
BTW, one thing we cab try in moving forward is, if Or just do it locally and patch crates using it That'd be an interesting test to see if it breaks anything |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
v0.5.5does a huge performance improvement forInputSize::Unknown. Especially it's helpful for async and sync IO because we don't know input size when IO stream was open.Local benches (
axum+tower+async-compressionandwrkfor load testing)