[16.0] pre-commit: bump setuptools-odoo to 3.3.2 to fix pkg_resources ImportError - #217
Open
DarioLodeiros wants to merge 1 commit into
Open
DarioLodeiros wants to merge 1 commit into
DarioLodeiros wants to merge 1 commit into
Conversation
setuptools-odoo 3.1.8 imports `pkg_resources`, which is no longer available in `setuptools >= 81`. As a result, the setuptools-odoo-make-default and setuptools-odoo-get-requirements pre-commit hooks now fail on every PR opened against this branch with `ModuleNotFoundError: No module named 'pkg_resources'`. Other OCA 16.0 repositories (server-tools, web, partner-contact, account-invoicing, ...) already moved to setuptools-odoo 3.3.2, which uses `importlib.metadata` and works with current setuptools versions.
This was referenced Jun 20, 2026
klodr
added a commit
to klodr/OCA-currency
that referenced
this pull request
Sep 12, 2026
… ImportError setuptools-odoo 3.1.8 imports the removed `pkg_resources` module, so the `setuptools-odoo-make-default` and `setuptools-odoo-get-requirements` hooks fail with `ModuleNotFoundError: No module named 'pkg_resources'` on recent setuptools (>= 81). This makes the pre-commit check red on every PR currently opened against this branch. Bump the hook to 3.3.2, same as OCA#217 for 16.0. Signed-off-by: Claude Perrin <klodr@users.noreply.github.com>
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
Bot
added
the
stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`setuptools-odoo` 3.1.8 imports `pkg_resources`, which is no longer available in `setuptools >= 81`. As a result, the `setuptools-odoo-make-default` and `setuptools-odoo-get-requirements` pre-commit hooks now fail on every PR opened against this branch with:
```
ModuleNotFoundError: No module named 'pkg_resources'
```
Example failure on a recent PR: https://github.com/OCA/currency/actions/runs/25795732013/job/75772439565
Fix
Bump `acsone/setuptools-odoo` from `3.1.8` to `3.3.2`, which uses `importlib.metadata` instead of `pkg_resources`. Other OCA 16.0 repositories already moved to 3.3.2:
Test plan