Repository navigation
Conversation
get_geo_equal_sql built the compared geometry with ST_GeomFromText(%s), without an SRID. PostGIS then creates the literal with SRID 0, which is never equal to a column stored with the field's SRID, so a direct geo_equal domain always returned an empty recordset, silently. Pass the field SRID as the other spatial operators already do in _get_postgis_comp_sql, and add a regression test for the direct (non-dict) form of geo_equal, which was not covered. Fixes OCA#471
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #471.
get_geo_equal_sql built the compared geometry with ST_GeomFromText(%s), i.e. SRID 0, so a direct geo_equal domain never matched a column stored with the field SRID and silently returned an empty recordset. The literal now carries the field SRID, as _get_postgis_comp_sql already does for the other operators.
Adds test_search_equals_direct_value: the direct form of geo_equal was not covered (the existing test only uses the dict form). It fails before the fix and passes after; full module suite green locally with PostGIS.
Thanks @lesdekock for the report and the analysis. Forward-ports to 17.0, 18.0 and 19.0 will follow.