Repository navigation
[18.0][FIX] hr_employee_calendar_planning: test only the field the module adds - #1672
Open
carlosdauden wants to merge 1 commit into
Open
carlosdauden wants to merge 1 commit into
carlosdauden wants to merge 1 commit into
Conversation
test_read_employees_internal_user read all the fields of an employee as an internal user, so it failed whenever another installed module adds a field to hr.employee that is not on hr.employee.public, e.g. mail_tracking (failed_message_ids) or base_search_mail_content (message_content) on mail.thread: "The fields message_content,failed_message_ids, which you are trying to read, are not available for employee public profiles". Check instead that calendar_ids is not among the fields an internal user reads without explicit fields, which is what this module is responsible for. It still fails without the groups on calendar_ids.
Contributor
|
Hi @pedrobaeza, @victoralmau, |
sergio-teruel
approved these changes
Nov 13, 2026
victoralmau
reviewed
Nov 16, 2026
victoralmau
left a comment
Member
There was a problem hiding this comment.
IMO, this has been fixed at #1667
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test added in db5518f (test_read_employees_internal_user) reads all the fields of an employee as an internal user, so it fails in any database where another module adds a field to hr.employee that is not on hr.employee.public. For example mail_tracking (failed_message_ids) or base_search_mail_content (message_content) on mail.thread: "The fields message_content,failed_message_ids, which you are trying to read, are not available for employee public profiles".
The test now checks only that calendar_ids is not among the fields an internal user reads without explicit fields, which is what this module is responsible for. Checked on clean databases: it passes with and without mail_tracking and base_search_mail_content, and it still fails if the groups on calendar_ids is removed.
@Tecnativa
ping @sergio-teruel @victoralmau